Syncing FileDescriptor causes problems with closed streams [173037611]

Fixed

Bug

Status Update

No update yet.

Description

ho...@gmail.com

created issue #1

Nov 12, 2020 01:54AM

DataStore Component used: datastore-core

DataStore Version used: 1.0.0-alpha02

Devices/Android versions reproduced on: Emulator/Pixel 3, API 30

I've created a sample project that demonstrates the issue here: https://github.com/chris-horner/DataStore-Bug

I've written a custom Serializer that attempts to encrypt and decrypt the data written to disk. The problem I've run into is that I need to close the OutputStream provided in writeTo(), as I'm making use of Okio's CipherSink. Closing the stream is how CipherSink writes final data to the stream.

However closing OutputStream causes SingleProcessDataStore to throw a java.io.SyncFailedException when it attempts to invoke

stream.fd.sync()

with the stracktrace being

java.io.SyncFailedException: sync failed
    at java.io.FileDescriptor.sync(Native Method)
    at androidx.datastore.SingleProcessDataStore.writeData$datastore_core_release(SingleProcessDataStore.kt:299)
    at androidx.datastore.SingleProcessDataStore.transformAndWrite(SingleProcessDataStore.kt:282)
    at androidx.datastore.SingleProcessDataStore$actor$1.invokeSuspend(SingleProcessDataStore.kt:165)

Comments

ho...@gmail.com <ho...@gmail.com> #2Nov 16, 2020 01:32AM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ro...@google.com <ro...@google.com> #3Nov 16, 2020 11:59PM

Marked as fixed.

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

ap...@google.com <ap...@google.com> #4Nov 17, 2020 01:50AM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Issue 173037611

Description

Issue summary

Comments

ho...@gmail.com <ho...@gmail.com> #2Nov 16, 2020 01:32AM

ro...@google.com <ro...@google.com> #3Nov 16, 2020 11:59PM

ap...@google.com <ap...@google.com> #4Nov 17, 2020 01:50AM

Add comment

Issue metadata