Fixed
Status Update
Comments
ki...@google.com <ki...@google.com>
il...@google.com <il...@google.com> #2
We'd accept a pull request for this if you'd like
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 205ca48fd552f665e52647b3bbee63839c7bd897
Author: Nicklas Ansman Giertz <nicklas@ansman.se>
Date: Thu Nov 12 21:57:48 2020
Migrate ShareCompat factory methods to constructors
The `from` methods for creating IntentBuilders and IntentReaders has
been deprecated and the constructor has been made public.
In addition to this there are now two ways of creating each class, one
from an Activity and one from the raw components.
Fixes: 173043501
Test: ShareCompatTest
Relnote: "ShareCompat now uses constructors for creation and the old
factory methods have been deprecated. You can now create both builders
and readers from a Context and an Activity is no longer required."
Change-Id: I315b68aff01ca931d38b934786e6d9b2174f720b
M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/ShareCompatTest.java
M core/core/src/main/java/androidx/core/app/ShareCompat.java
https://android-review.googlesource.com/1498197
Branch: androidx-master-dev
commit 205ca48fd552f665e52647b3bbee63839c7bd897
Author: Nicklas Ansman Giertz <nicklas@ansman.se>
Date: Thu Nov 12 21:57:48 2020
Migrate ShareCompat factory methods to constructors
The `from` methods for creating IntentBuilders and IntentReaders has
been deprecated and the constructor has been made public.
In addition to this there are now two ways of creating each class, one
from an Activity and one from the raw components.
Fixes: 173043501
Test: ShareCompatTest
Relnote: "ShareCompat now uses constructors for creation and the old
factory methods have been deprecated. You can now create both builders
and readers from a Context and an Activity is no longer required."
Change-Id: I315b68aff01ca931d38b934786e6d9b2174f720b
M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/ShareCompatTest.java
M core/core/src/main/java/androidx/core/app/ShareCompat.java
il...@google.com <il...@google.com> #5
Thanks for fixing this! New constructors (which replace the now deprecated static from()
methods) for IntentReader
and IntentBuilder
will be available in the next build of Core.
Description
It would be very helpful if
ShareCompat.IntentBuilder.from(Context, ComponentName)
was made public. Now thatActivityResultContract
exists it would be immensely useful to not require anActivity
to useShareCompat
since contracts only receive aContext
.