Gradient APIs should have ability to define in fractional terms instead of pixels [173066799]

Fixed

Feature Request

Status Update

No update yet.

Description

le...@google.com

created issue #1

Nov 12, 2020 02:06AM

I've seen this come up in various places and I think it is a very common need. It also was an issue that I myself ran into when using compose. It seems like _most_ of the time you want to define a gradient's color stops in terms of a fraction of the size of the node they're modifying, but this isn't possible with current gradient APIs. Unfortunately, one needs to wait to create their gradient until after layout has occurred so they can create a pixel-based gradient from the size.

I suggest we revamp or add some APIs that make this easier.

Comments

nj...@google.com <nj...@google.com> #2Nov 13, 2020 06:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

al...@gmail.com <al...@gmail.com> #3Nov 15, 2020 02:24AM

+1 I agree it would be nice to be able to create gradients using percentages rather than pixels!

al...@gmail.com <al...@gmail.com> #4Nov 24, 2020 06:30PM

I filed a pretty similar request here regarding the KeyframesSpec API as well: https://issuetracker.google.com/issues/174070165

ap...@google.com <ap...@google.com> #5Dec 9, 2020 10:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e9f976c645e2c449df86e2a22e3e43da2d3595b9
Author: Nader Jawad <njawad@google.com>
Date: Tue Dec 08 12:21:10 2020

Add support for deferred brush creation

Relnote: "Refactored ShaderBrush to
lazily create a shader instance when
sizing information of the drawing
environment is available.
This is useful to define gradients that
occupy the full drawing bounds of a composable
at composition time, without having to
implement custom DrawModifier implementations.

Deprecated gradient function constructor APIs
in favor of factory methods on a Gradient object."

Bug: 173066799
Test: Added tests to DrawScopeTest
Change-Id: I511fc09bdeb4b41127de4a6b1e616688b10295f5

M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BorderSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/DrawBackgroundSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollerSamples.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Offset.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/OffsetTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
A compose/ui/ui-graphics/samples/src/main/java/androidx/compose/ui/graphics/samples/BrushSamples.kt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/ShaderTest.kt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/drawscope/DrawScopeTest.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Brush.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Shader.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/CanvasDrawScope.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/inspector/ParameterFactoryTest.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/VectorGraphicsDemo.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DrawModifierSample.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/vector/DesktopXmlVectorParser.kt

https://android-review.googlesource.com/1519258

nj...@google.com <nj...@google.com> Dec 10, 2020 02:02AM

Marked as fixed.

Issue 173066799