Gradient APIs should have ability to define in fractional terms instead of pixels [173066799]

Fixed

Feature Request

Status Update

No update yet.

Description

le...@google.com

created issue #1

Nov 12, 2020 02:06AM

I've seen this come up in various places and I think it is a very common need. It also was an issue that I myself ran into when using compose. It seems like _most_ of the time you want to define a gradient's color stops in terms of a fraction of the size of the node they're modifying, but this isn't possible with current gradient APIs. Unfortunately, one needs to wait to create their gradient until after layout has occurred so they can create a pixel-based gradient from the size.

I suggest we revamp or add some APIs that make this easier.

Comments

nj...@google.com <nj...@google.com> #2Nov 13, 2020 06:46PM

We will see :)

al...@gmail.com <al...@gmail.com> #3Nov 15, 2020 02:24AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a9b67eca31e73a3f975b53e22a9e5983e2d76864
Author: Filip Pavlis <pavlis@google.com>
Date: Thu Oct 01 15:32:27 2020

Add FLAG_SECURE on Dialog and Popup.

Added a new way on how to pass platform specific parameters for popups
and dialogs.

Also renamed children to content. And made expect / actual to be
internal for dialog as it is for popup.

Bug: 143778148
Bug: 143778149
Test: Added tests for both dialog and popup.
Relnote: "Popups and dialogs now inherit FLAG_SECURE from parent Window.
Also added option to configure this explicitly".

Change-Id: I649663482e91757df751315b03fee9867b580e96

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/AndroidManifest.xml
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogSecureFlagTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PopupDismissTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PopupSecureFlagTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PopupTestUtils.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/SecureFlagPolicy.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionLayout.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/window/Dialog.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/window/Popup.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopDialog.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.kt

https://android-review.googlesource.com/1444435

al...@gmail.com <al...@gmail.com> #4Nov 24, 2020 06:30PM

Thanks for your feedback! We have just landed a CL that enables to configure a FLAG_SECURE on a dialog. By default it will inherit it from window launching it, so all compose popups from now on should inherit the flag. The flag can be also configured for AlertDialog. This will be available in the next release.

ap...@google.com <ap...@google.com> #5Dec 9, 2020 10:59PM

I am tremendously grateful that you added fixes for this and https://issuetracker.google.com/issues/143778148!

For testing purposes, by "the next release", do you mean alpha05? I don't know when your internal cutoff is for what makes it into a particular release.

Thanks again!

nj...@google.com <nj...@google.com> Dec 10, 2020 02:02AM

Marked as fixed.

Issue 173066799