ShareCompat.IntentBuilder + startChooser() doesn't grant system's share sheet UI access to content [173137936]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

ck...@gmail.com

created issue #1

Nov 12, 2020 09:07PM

ShareCompat.IntentBuilder doesn't create share intents that have the FLAG_GRANT_READ_URI_PERMISSION flag set and EXTRA_STREAM values added to the intent's clip data.

Often that's not a problem because Intent.migrateExtraStreamToClipData() makes the appropriate modifications before the intent leaves the process.
Intent.migrateExtraStreamToClipData() has support for modifying the target intent of a chooser intent. However, the chooser intent itself isn't modified. This leads to the share sheet in Android 10+ not being able to access the content to show the display name or a preview image.

Reproduce with:

ShareCompat.IntentBuilder.from(activity)
    .setType("image/jpeg")
    .addStream(contentUri)
    .startChooser()

You'll notice that the share sheet doesn't show a preview image. logcat will contain a message similar to this one:

java.lang.SecurityException: Permission Denial: reading androidx.core.content.FileProvider uri content://example/file.png from pid=x, uid=1000 requires the provider be exported, or grantUriPermission()
    at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:820)
    at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:684)
    at android.content.ContentProvider$Transport.enforceFilePermission(ContentProvider.java:674)
    at android.content.ContentProvider$Transport.openTypedAssetFile(ContentProvider.java:548)
    at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:327)
    at android.os.Binder.execTransactInternal(Binder.java:1154)
    at android.os.Binder.execTransact(Binder.java:1123)

Note that the final share target will have access to the content. I don't know why this actually works if the URI permission hasn't been granted to the system process showing the share sheet 🤷

Comments

ck...@gmail.com <ck...@gmail.com> #2Nov 12, 2020 09:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> Nov 12, 2020 09:44PM

Reassigned to il...@google.com.

ap...@google.com <ap...@google.com> #3Nov 18, 2020 02:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c20453d937dd1af6b681aa42404205c3976adad1
Author: cketti <cketti@gmail.com>
Date: Thu Nov 12 21:30:05 2020

Set clip data when sharing streams using ShareCompat

The mechanism in Intent.createChooser() to migrate clip data and flags
from the target intent only works if the target intent actually contains
the necessary flags and clip data. If that's not the case the content
preview in the share sheet won't work because it won't be able to access
the content.
With this change the share intent contains the necessary clip data items
and flags by the time Intent.createChooser() is called.

Relnote: "Set clip data and grant uri read permission when sharing streams using ShareCompat"
Bug: 173137936
Test: ShareCompatTest
Change-Id: I4aa318b146206e4e5cd028b7e3798c9d895d8324

M core/core/src/androidTest/java/androidx/core/app/ShareCompatTest.java
M core/core/src/main/java/androidx/core/app/ShareCompat.java

https://android-review.googlesource.com/1497445

il...@google.com <il...@google.com> #4Nov 18, 2020 10:04PM

Marked as fixed.

Thanks for the pull request! This will be in the next Core release.

Issue 173137936

Description

Issue summary

Comments

ck...@gmail.com <ck...@gmail.com> #2Nov 12, 2020 09:40PM

il...@google.com <il...@google.com> Nov 12, 2020 09:44PM

ap...@google.com <ap...@google.com> #3Nov 18, 2020 02:03AM

il...@google.com <il...@google.com> #4Nov 18, 2020 10:04PM

Add comment

Issue metadata