Fixed
Status Update
Comments
ck...@gmail.com <ck...@gmail.com> #2
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #3
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
il...@google.com <il...@google.com> #4
Hi Nona,
Can you please schedule a release after you merge the fix?
Description
ShareCompat.IntentBuilder
doesn't create share intents that have theFLAG_GRANT_READ_URI_PERMISSION
flag set andEXTRA_STREAM
values added to the intent's clip data.Often that's not a problem because
Intent.migrateExtraStreamToClipData()
makes the appropriate modifications before the intent leaves the process.Intent.migrateExtraStreamToClipData()
has support for modifying the target intent of a chooser intent. However, the chooser intent itself isn't modified. This leads to the share sheet in Android 10+ not being able to access the content to show the display name or a preview image.Reproduce with:
You'll notice that the share sheet doesn't show a preview image. logcat will contain a message similar to this one:
Note that the final share target will have access to the content. I don't know why this actually works if the URI permission hasn't been granted to the system process showing the share sheet 🤷