Backport setSystemBarsBehavior() in WindowInsetsControllerCompat [173203649]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Nov 13, 2020 10:46PM

BEHAVIOR_SHOW_BARS_BY_SWIPE replaces SYSTEM_UI_FLAG_IMMERSIVE as per its documentation and similarly for BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE with SYSTEM_UI_FLAG_IMMERSIVE_STICKY.

WindowInsetsControllerCompat should correctly set those deprecated flags on pre-API 30 devices when you call show() or hide().

Comments

ki...@google.com <ki...@google.com> Nov 13, 2020 10:49PM

Status: New

ch...@google.com <ch...@google.com> Nov 15, 2020 03:44PM

Assigned to ca...@google.com.

ol...@gmail.com <ol...@gmail.com> #2Dec 5, 2020 03:59AM

Project: platform/frameworks/support
Branch: androidx-main

commit 016fab7f37837deb6e0924730ed70b81042c36db
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:16:26 2022

Converting `query interceptor` related files in `room-runtime` from Java to Kotlin.

Test: N/A
Bug: 206859668
Relnote: Converting `query` related files in `room-runtime` from Java to Kotlin.
Change-Id: I92b932b1a1037c68195140ffb038f8add17d8de4

M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorStatement.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorProgram.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/1960726

ga...@gmail.com <ga...@gmail.com> #3Dec 8, 2020 12:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 049d12d74b775c193e641a3fd11fb4b3c5c20dc6
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:37:31 2022

Converting `paging` related files in `room-runtime` from Java to Kotlin.

Test: LimitOffsetDataSourceTest.java
Bug: 206859668
Relnote: Converting `paging` related files in `room-runtime` from Java to Kotlin.
Change-Id: I82fc81469540315dbe4865ccde68396a4339dfd9

M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/paging/LimitOffsetDataSource.kt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/build.gradle

https://android-review.googlesource.com/1960734

mk...@qa.edx.org <mk...@qa.edx.org> #4Dec 28, 2020 06:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 04773d8513b7ce6fbea263031c7618144c6e695d
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:34:19 2022

Converting `util` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests in Java for util/. These will be migrated later as a safe migration measure.
Bug: 206859668
Relnote: Converting `util` related files in `room-runtime` from Java to Kotlin.
Change-Id: I697ee52d9234358fd83dc8d94c66d4f2b849fc1b

M room/room-runtime/src/test/java/androidx/room/util/UUIDUtilTest.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/util/StringUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FileUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FtsTableInfo.kt
M room/room-runtime/src/main/java/androidx/room/util/UUIDUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/CursorUtil.kt
M room/room-runtime/src/test/java/androidx/room/util/CursorUtilTest.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/util/TableInfo.kt
M room/room-compiler/build.gradle
M room/room-runtime/api/current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/StringToIntListConverters.kt
M room/room-runtime/src/main/java/androidx/room/util/ViewInfo.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt

https://android-review.googlesource.com/1960732

ak...@gmail.com <ak...@gmail.com> #5Jan 1, 2021 06:21AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9e87eb671143418ff2f2412dc43516582c1e775f
Author: Elif Bilgin <elifbilgin@google.com>
Date: Mon Feb 07 22:00:47 2022

Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin.

Test: BuilderTest.kt, InvalidationTrackerTest.kt, InvalidationLiveDataContainerTest.kt, ObservedTableTrackerTest.kt
Bug: 206859668
Relnote: Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin. This includes a source incompatible change for Kotlin users, which will require them to declare their `onInvalidate()` in their `Observer` to have a param of type `Set` and not `MutableSet`.
Change-Id: If2069426a29fffe312a58fcd3e116551090c0b4e

M room/room-paging/src/androidTest/kotlin/androidx/room/InvalidationTrackerExtRoomPaging.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/InvalidationTrackerTrojan.java
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-common/build.gradle
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationService.kt
M room/benchmark/src/androidTest/java/androidx/room/benchmark/InvalidationTrackerBenchmark.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
A room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M room/room-paging/src/main/java/androidx/room/paging/util/ThreadSafeInvalidationObserver.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/PagingSourceTest.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/test/java/androidx/room/BuilderTest.java
M room/room-runtime/src/main/java/androidx/room/InvalidationLiveDataContainer.kt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/InvalidationTrackerExt.kt
M room/room-runtime/src/main/java/androidx/room/Room.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationLiveDataContainerTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SyncTriggersConcurrencyTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.java
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/room-runtime/src/test/java/androidx/room/BuilderTest_TestDatabase_Impl.java

https://android-review.googlesource.com/1976130

ko...@gmail.com <ko...@gmail.com> #6Jan 16, 2021 04:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3267211f72168a905ff880a4e34558185dc6c313
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Apr 27 14:28:44 2022

Converting `auto closer` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting `auto closer` related files in `room-runtime` from Java to Kotlin.
Change-Id: I6ee76590c1d110a4bb46219c126ef79177e3c975

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt

https://android-review.googlesource.com/2043166

li...@gmail.com <li...@gmail.com> #7Jan 23, 2021 06:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit a6f3b46c1dd9f4f1b419462c50451a120a863232
Author: Elif Bilgin <elifbilgin@google.com>
Date: Thu Apr 14 16:25:45 2022

Converting the final set of Java files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting the final set of Java files in `room-runtime` from Java to Kotlin.
Change-Id: I96c25112c3ab32f8df71c1408c8006bdae1b3b7f

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelperFactory.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/SQLiteCopyOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/DatabaseConfiguration.kt
M room/room-runtime/src/main/java/androidx/room/EntityInsertionAdapter.kt
M room/room-runtime/src/main/java/androidx/room/EntityDeletionOrUpdateAdapter.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SharedSQLiteStatement.kt
M room/room-runtime/api/current.txt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/src/main/java/androidx/room/ExperimentalRoomApi.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/DelegatingOpenHelper.kt

https://android-review.googlesource.com/2065333

al...@gmail.com <al...@gmail.com> #8Jan 25, 2021 09:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3e34c01fd2679c1deb0d5ef4cdd76823f425a3ec
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:58:34 2022

Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.
Change-Id: Ie4b55827902c6ddcc4cc004de8bb5286823e9ab5

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/TransactionExecutor.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/RoomSQLiteQueryTest.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.kt
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-paging-guava/src/main/java/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-compiler/src/test/data/databasewriter/output/ComplexDatabase.java
M room/room-ktx/src/main/java/androidx/room/RoomDatabaseExt.kt
M room/room-runtime/src/main/java/androidx/room/RoomSQLiteQuery.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/RoomOpenHelper.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M development/build_log_simplifier/messages.ignore
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/SQLiteOpenHelperWriter.kt
M room/room-ktx/src/test/java/androidx/room/CoroutinesRoomTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/AlteredTableColumnOrderTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/SampleDatabaseService.java
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt

https://android-review.googlesource.com/1961019

ii...@gmail.com <ii...@gmail.com> #9Feb 3, 2021 05:18PM

I assumed the old method is implemented since Core is on beta release already, but upon closer inspection the method only implemented for API 30. Revert revert we go...

jo...@gmail.com <jo...@gmail.com> #10Feb 20, 2021 10:44PM

Hi, is there someone already working on this? I needed this feature so I implemented it. I can improve it and submit a pull request :D

ca...@google.com <ca...@google.com> #11Feb 22, 2021 10:07AM

Thank you all for reporting this bug. We are actively working on this but the backport implementation uncovered some other bugs that need to be fixed and tested in order to submit all the changes. https://android-review.googlesource.com/c/platform/frameworks/support/+/1598475

[Deleted User] <[Deleted User]> #12Mar 15, 2021 12:48PM

This is blocking for the correct usage of WindowInsetsControllerCompat.

Is someone still working on this?

lu...@toyrocketscience.com <lu...@toyrocketscience.com> #13Apr 8, 2021 09:05AM

+1 on this issue

ap...@google.com <ap...@google.com> #14Apr 14, 2021 04:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 480d10395d28bf22e9f4539f4b992a344628779b
Author: Vadim Caen <caen@google.com>
Date: Mon Feb 08 16:23:39 2021

Implement setSystemBarsBehavior for pre 30 SDK

Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_swipe
Test:
WindowInsetsControllerCompatActivityTest#systemBarsBehavior_transient
Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_touch
Bug: 173203649

Change-Id: I062c841f0e4201fddfcf1489dbfaff605bebbdb6

M core/core/src/androidTest/java/androidx/core/view/WindowInsetsAnimationCompatActivityTest.kt
M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsAnimationCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java
M samples/Support4Demos/src/main/java/com/example/android/supportv4/view/WindowInsetsControllerPlayground.kt
M samples/Support4Demos/src/main/res/layout/activity_insets_controller.xml

https://android-review.googlesource.com/1612119

ca...@google.com <ca...@google.com> Apr 14, 2021 04:07PM

Marked as fixed.

lb...@gmail.com <lb...@gmail.com> #15Apr 14, 2021 04:25PM

@14 I forgot why I even starred this...
Is this a deprecation issue, or something to implement for new/old API of Android?

ca...@google.com <ca...@google.com> #16Apr 14, 2021 05:29PM

Android R introduced WindowInsetsController.setSystemBarsBehavior() and the API was added to Androidx but the backport was not implemented. It should be release in core:1.5.0 stable

jd...@xooloo.com <jd...@xooloo.com> #17Apr 28, 2021 10:47AM

getSystemBarsBehavior() is still unimplemented…

du...@gmail.com <du...@gmail.com> #18May 3, 2021 04:02AM

kotlin-> BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE is still acting like BEHAVIOR_SHOW_BARS_BY_TOUCH in core-ktx:1.6.0-alpha02 (assuming I have the right library) on api 28 and others in the emulator. Have to include window.decorView.systemUiVisibility = View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY to get previous behavior.

ol...@gmail.com <ol...@gmail.com> #19Jun 10, 2021 04:29AM

@#18 support for setSystemBarsBehavior on SDK < 30 has been added in core-ktx:1.6.0-alpha03, see here: https://developer.android.com/jetpack/androidx/releases/core#1.6.0-alpha03 I've updated my answer on stackoverflow to reflect: https://stackoverflow.com/a/64828028/3422470

lb...@gmail.com <lb...@gmail.com> #20Jun 10, 2021 06:55AM

Can anyone please demonstrate the use of it, and a screenshot with it vs without it?