Backport setSystemBarsBehavior() in WindowInsetsControllerCompat [173203649]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Nov 13, 2020 10:46PM

BEHAVIOR_SHOW_BARS_BY_SWIPE replaces SYSTEM_UI_FLAG_IMMERSIVE as per its documentation and similarly for BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE with SYSTEM_UI_FLAG_IMMERSIVE_STICKY.

WindowInsetsControllerCompat should correctly set those deprecated flags on pre-API 30 devices when you call show() or hide().

Comments

ki...@google.com <ki...@google.com> Nov 13, 2020 10:49PM

Status: New

ch...@google.com <ch...@google.com> Nov 15, 2020 03:44PM

Assigned to ca...@google.com.

ol...@gmail.com <ol...@gmail.com> #2Dec 5, 2020 03:59AM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ga...@gmail.com <ga...@gmail.com> #3Dec 8, 2020 12:58PM

Thanks for the report!

mk...@qa.edx.org <mk...@qa.edx.org> #4Dec 28, 2020 06:06PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ak...@gmail.com <ak...@gmail.com> #5Jan 1, 2021 06:21AM

deleted

ko...@gmail.com <ko...@gmail.com> #6Jan 16, 2021 04:17PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

li...@gmail.com <li...@gmail.com> #7Jan 23, 2021 06:30PM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Realme X2 Pro Android 10 as well. (Core ktx Version 1.5.0-beta01)

al...@gmail.com <al...@gmail.com> #8Jan 25, 2021 09:59PM

Bug is real on every android 10 device wich i have on all alphas and beta core ctx versions.

ii...@gmail.com <ii...@gmail.com> #9Feb 3, 2021 05:18PM

I assumed the old method is implemented since Core is on beta release already, but upon closer inspection the method only implemented for API 30. Revert revert we go...

jo...@gmail.com <jo...@gmail.com> #10Feb 20, 2021 10:44PM

Hi, is there someone already working on this? I needed this feature so I implemented it. I can improve it and submit a pull request :D

ca...@google.com <ca...@google.com> #11Feb 22, 2021 10:07AM

Thank you all for reporting this bug. We are actively working on this but the backport implementation uncovered some other bugs that need to be fixed and tested in order to submit all the changes. https://android-review.googlesource.com/c/platform/frameworks/support/+/1598475

[Deleted User] <[Deleted User]> #12Mar 15, 2021 12:48PM

This is blocking for the correct usage of WindowInsetsControllerCompat.

Is someone still working on this?

lu...@toyrocketscience.com <lu...@toyrocketscience.com> #13Apr 8, 2021 09:05AM

+1 on this issue

ap...@google.com <ap...@google.com> #14Apr 14, 2021 04:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 480d10395d28bf22e9f4539f4b992a344628779b
Author: Vadim Caen <caen@google.com>
Date: Mon Feb 08 16:23:39 2021

Implement setSystemBarsBehavior for pre 30 SDK

Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_swipe
Test:
WindowInsetsControllerCompatActivityTest#systemBarsBehavior_transient
Test: WindowInsetsControllerCompatActivityTest#systemBarsBehavior_touch
Bug: 173203649

Change-Id: I062c841f0e4201fddfcf1489dbfaff605bebbdb6

M core/core/src/androidTest/java/androidx/core/view/WindowInsetsAnimationCompatActivityTest.kt
M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsAnimationCompat.java
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java
M samples/Support4Demos/src/main/java/com/example/android/supportv4/view/WindowInsetsControllerPlayground.kt
M samples/Support4Demos/src/main/res/layout/activity_insets_controller.xml

https://android-review.googlesource.com/1612119

ca...@google.com <ca...@google.com> Apr 14, 2021 04:07PM

Marked as fixed.

lb...@gmail.com <lb...@gmail.com> #15Apr 14, 2021 04:25PM

@14 I forgot why I even starred this...
Is this a deprecation issue, or something to implement for new/old API of Android?

ca...@google.com <ca...@google.com> #16Apr 14, 2021 05:29PM

Android R introduced WindowInsetsController.setSystemBarsBehavior() and the API was added to Androidx but the backport was not implemented. It should be release in core:1.5.0 stable

jd...@xooloo.com <jd...@xooloo.com> #17Apr 28, 2021 10:47AM

getSystemBarsBehavior() is still unimplemented…

du...@gmail.com <du...@gmail.com> #18May 3, 2021 04:02AM

kotlin-> BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE is still acting like BEHAVIOR_SHOW_BARS_BY_TOUCH in core-ktx:1.6.0-alpha02 (assuming I have the right library) on api 28 and others in the emulator. Have to include window.decorView.systemUiVisibility = View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY to get previous behavior.

ol...@gmail.com <ol...@gmail.com> #19Jun 10, 2021 04:29AM

@#18 support for setSystemBarsBehavior on SDK < 30 has been added in core-ktx:1.6.0-alpha03, see here: https://developer.android.com/jetpack/androidx/releases/core#1.6.0-alpha03 I've updated my answer on stackoverflow to reflect: https://stackoverflow.com/a/64828028/3422470

lb...@gmail.com <lb...@gmail.com> #20Jun 10, 2021 06:55AM

Can anyone please demonstrate the use of it, and a screenshot with it vs without it?