Crash when trying to menu from onPrepareOptionsMenu [173203654]

Fixed

Bug

Status Update

No update yet.

Description

vo...@gmail.com

created issue #1

Nov 14, 2020 03:01AM

Build: AI-201.8743.12.41.6953283, 202011050241,

AI-201.8743.12.41.6953283, JRE 1.8.0_242-release-1644-b3-6222593x64 JetBrains s.r.o, OS Linux(amd64) v5.4.0-53-generic, screens 3440x1440

AS: 4.1.1; Kotlin plugin: 1.4.10-release-Studio4.1-1; Android Gradle Plugin: 4.1.1; Gradle: 6.5; NDK: from local.properties: (not specified), latest from SDK: 21.3.6528147; LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.16.3

Affected version: androidx.fragment:fragment-ktx:1.2.5

Note: It looks like all versions starting from 1.2+ are affected

Description

When you have view pager with nested fragment that shows menu it will crash if you try to access menu items from onPrepareOptionsMenu.

Steps to reproduce

Add new ViewPager
Add first page - Fragment1
Add second page - Fragment2
In Fragment2 add nested Fragment21 and enable setHasOptionsMenu(true), also add new menu specific to this fragment
Try to access menu items of the Fragment21 from onPrepareOptionsMenu

Expected behavior

you should be able to access inflated menu, or
onPrepareOptionsMenu should never be called if menu is not inflated

Actual behavior

Menu was never inflated
It will crash when trying to access menu items from onPrepareOptionsMenu

Additional information

Looking through the changes I was able to pinpoint it to this behavior change: https://android.googlesource.com/platform/frameworks/support/+/4809e01d4153a5ba68cb68f36544baa1b90738c0

We are now also checking for parent menu visibility but only in dispatchCreateOptionsMenu, which means we would call dispatchPrepareOptionsMenu with no menu inflated since we skipped it.

Possible fix

Add matching check to all dispatch*Menu methods, or
Remove check from dispatchCreateOptionsMenu

Demo repository:

You can find repository with repro steps here: https://github.com/vovkab/fragment-menu-crash

Comments

il...@google.com <il...@google.com> #2Dec 2, 2020 10:33PM

Assigned to jb...@google.com.

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ap...@google.com <ap...@google.com> #3Dec 4, 2020 04:29AM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

il...@google.com <il...@google.com> #4Dec 8, 2020 12:04AM

Marked as fixed.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Issue 173203654

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Dec 2, 2020 10:33PM

ap...@google.com <ap...@google.com> #3Dec 4, 2020 04:29AM

il...@google.com <il...@google.com> #4Dec 8, 2020 12:04AM

Add comment

Issue metadata