Crash when trying to menu from onPrepareOptionsMenu [173203654]

Fixed

Bug

Status Update

No update yet.

Description

vo...@gmail.com

created issue #1

Nov 14, 2020 03:01AM

Build: AI-201.8743.12.41.6953283, 202011050241,

AI-201.8743.12.41.6953283, JRE 1.8.0_242-release-1644-b3-6222593x64 JetBrains s.r.o, OS Linux(amd64) v5.4.0-53-generic, screens 3440x1440

AS: 4.1.1; Kotlin plugin: 1.4.10-release-Studio4.1-1; Android Gradle Plugin: 4.1.1; Gradle: 6.5; NDK: from local.properties: (not specified), latest from SDK: 21.3.6528147; LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.16.3

Affected version: androidx.fragment:fragment-ktx:1.2.5

Note: It looks like all versions starting from 1.2+ are affected

Description

When you have view pager with nested fragment that shows menu it will crash if you try to access menu items from onPrepareOptionsMenu.

Steps to reproduce

Add new ViewPager
Add first page - Fragment1
Add second page - Fragment2
In Fragment2 add nested Fragment21 and enable setHasOptionsMenu(true), also add new menu specific to this fragment
Try to access menu items of the Fragment21 from onPrepareOptionsMenu

Expected behavior

you should be able to access inflated menu, or
onPrepareOptionsMenu should never be called if menu is not inflated

Actual behavior

Menu was never inflated
It will crash when trying to access menu items from onPrepareOptionsMenu

Additional information

Looking through the changes I was able to pinpoint it to this behavior change: https://android.googlesource.com/platform/frameworks/support/+/4809e01d4153a5ba68cb68f36544baa1b90738c0

We are now also checking for parent menu visibility but only in dispatchCreateOptionsMenu, which means we would call dispatchPrepareOptionsMenu with no menu inflated since we skipped it.

Possible fix

Add matching check to all dispatch*Menu methods, or
Remove check from dispatchCreateOptionsMenu

Demo repository:

You can find repository with repro steps here: https://github.com/vovkab/fragment-menu-crash

Comments

il...@google.com <il...@google.com> #2Dec 2, 2020 10:33PM

Assigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

ap...@google.com <ap...@google.com> #3Dec 4, 2020 04:29AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ea9e9a8978b26c9cd05ec0794f90ac11b2be06e6
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 03 14:33:34 2020

Ensure onPrepareOptionsMenu considers parent menu visibility

onCreateOptionsMenu already has child fragment consider parent menu
visiblity but onPrepareOptionsMenu does not. This means that child
fragments that have parents with no menu, will still get a callback to
onPrepareOptionsMenu, which will result in a crash.

We should make sure onPrepareOptionsMenu also considers if the parent
menu is visible.

RelNote: "`onPrepareOptionsMenu()` now follows the same logic as
`onCreateOptionsMenu()` and is no longer called when a parent fragment
calls `setMenuVisibility(false)`."
Test: OptionsMenuFragmentTest
Bug: 173203654

Change-Id: Id7de8156980c09e6ece0d977950b4844eb10d516

M fragment/fragment/src/androidTest/java/androidx/fragment/app/OptionsMenuFragmentTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1516804

il...@google.com <il...@google.com> #4Dec 8, 2020 12:04AM

Marked as fixed.

This has been fixed internally and will be available in Fragment 1.3.0-rc01.

Issue 173203654

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Dec 2, 2020 10:33PM

ap...@google.com <ap...@google.com> #3Dec 4, 2020 04:29AM

il...@google.com <il...@google.com> #4Dec 8, 2020 12:04AM

Add comment

Issue metadata