Changing text while selection is active could crash an App [173215242]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 16, 2020 10:21AM

There is a problem if we dynamically change selectable text. If selection outranges new text — it crashes. Code to reproduce:

class DemoActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val text = mutableStateOf("Hello world, Hello world Hello world Hello world" +
            "Hello worldHello world Hello world Hello world  Hello world")
        setContent {
            Column {
                SelectionContainer {
                    Text(
                        text = text.value
                    )
                }
            }
        }

        Timer().scheduleAtFixedRate(object : TimerTask() {
            override fun run() {
                text.value = text.value.substring(0 until (text.value.length - 1))
            }

        }, 1000, 1000 );
    }
}

Screen Recording 2020-11-12 at 11.52.59.mov

7.5 MB

Download

Comments

si...@google.com <si...@google.com> Nov 16, 2020 05:03PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> #2Nov 16, 2020 07:32PM

Reassigned to ha...@google.com.

added crash logs visible in the video

Andrei, can you please attach the crash logs?

Mon Nov 16 2020 11:31:53 GMT-0800 (Pacific Standard Time).png

193 KB

View

Download

Mon Nov 16 2020 11:32:08 GMT-0800 (Pacific Standard Time).png

193 KB

View

Download

ha...@google.com <ha...@google.com> Dec 5, 2020 12:22AM

Accepted by ha...@google.com.

ap...@google.com <ap...@google.com> #3Dec 10, 2020 07:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9085c8850e0db34eea99197043631115a118551f
Author: haoyu <haoyuchang@google.com>
Date: Tue Dec 08 12:01:06 2020

Clear selection when Selectable gets updated

Bug: 173826389
Bug: 173215242
Test: ./gradlew test
RelNote: "Introduced SelectionRegistrar.notifySelectableChange to notify Selectable updates to SelectionManager."
Change-Id: I6ff3055300ca7316ad644a4bcf7872d0d48878b8

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrar.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrarImpl.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopSelectionRegistrar.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/selection/SelectionManagerTest.kt

https://android-review.googlesource.com/1519950

ha...@google.com <ha...@google.com> Dec 10, 2020 08:18PM

Marked as fixed.

Issue 173215242

Description

Issue summary

Comments

si...@google.com <si...@google.com> Nov 16, 2020 05:03PM

si...@google.com <si...@google.com> #2Nov 16, 2020 07:32PM

ha...@google.com <ha...@google.com> Dec 5, 2020 12:22AM

ap...@google.com <ap...@google.com> #3Dec 10, 2020 07:56PM

ha...@google.com <ha...@google.com> Dec 10, 2020 08:18PM

Add comment

Issue metadata