Fixed
Status Update
Comments
si...@google.com <si...@google.com>
si...@google.com <si...@google.com> #2
added crash logs visible in the video
Andrei, can you please attach the crash logs?
ha...@google.com <ha...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9085c8850e0db34eea99197043631115a118551f
Author: haoyu <haoyuchang@google.com>
Date: Tue Dec 08 12:01:06 2020
Clear selection when Selectable gets updated
Bug: 173826389
Bug: 173215242
Test: ./gradlew test
RelNote: "Introduced SelectionRegistrar.notifySelectableChange to notify Selectable updates to SelectionManager."
Change-Id: I6ff3055300ca7316ad644a4bcf7872d0d48878b8
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrar.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrarImpl.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopSelectionRegistrar.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/selection/SelectionManagerTest.kt
https://android-review.googlesource.com/1519950
Branch: androidx-master-dev
commit 9085c8850e0db34eea99197043631115a118551f
Author: haoyu <haoyuchang@google.com>
Date: Tue Dec 08 12:01:06 2020
Clear selection when Selectable gets updated
Bug: 173826389
Bug: 173215242
Test: ./gradlew test
RelNote: "Introduced SelectionRegistrar.notifySelectableChange to notify Selectable updates to SelectionManager."
Change-Id: I6ff3055300ca7316ad644a4bcf7872d0d48878b8
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrar.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionRegistrarImpl.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopSelectionRegistrar.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/selection/SelectionManagerTest.kt
Description
There is a problem if we dynamically change selectable text. If selection outranges new text — it crashes. Code to reproduce: