Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
since these are in public API (:/) we need to do this in 1.2
no...@gradle.com
since it is already marked as deprecated, we can probably do it by now.
no...@gradle.com
Opening diff shortly
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
mt...@gmail.com
Still hitting issue using AGP 7.1.2 and nav args 2.4.1.
In which AGP + nav args library combination has the issue been fixed?
Is now the sensitivity marked as PathSensitivity.RELATIVE as gradle suggested?
In which AGP + nav args library combination has the issue been fixed?
Is now the sensitivity marked as PathSensitivity.RELATIVE as gradle suggested?
ga...@migrosonline.ch
Also seeing that the current configuration still results in uncacheable tasks when using remote build cache (same versions as mentioned in the previous post). Would be really nice if we could get this working.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3bd47a4d38076ca16ac8e18e18e91c01edecfc97
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Apr 15 14:38:00 2022
Change the PathSensitive setting in ArgumentsGenTask
Changing the PathSensitivety from absolute to relative for the
navigationFiles variable in ArgumentsGenerationTasks.
RelNote: "Navigation SafeArgs now uses `PathSensitivity.RELATIVE` to
allow for cache relocateability."
Test: safe args gradle plugin test
Bug: 173420454
Change-Id: I5f67ced6e860f301678ba9f6e77683f1061ebf59
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
https://android-review.googlesource.com/2064621
Branch: androidx-main
commit 3bd47a4d38076ca16ac8e18e18e91c01edecfc97
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Apr 15 14:38:00 2022
Change the PathSensitive setting in ArgumentsGenTask
Changing the PathSensitivety from absolute to relative for the
navigationFiles variable in ArgumentsGenerationTasks.
RelNote: "Navigation SafeArgs now uses `PathSensitivity.RELATIVE` to
allow for cache relocateability."
Test: safe args gradle plugin test
Bug: 173420454
Change-Id: I5f67ced6e860f301678ba9f6e77683f1061ebf59
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
no...@gradle.com
When will this be available in a release?
Description
Version used: 2.3.1
The `navigationFiles` input to the `ArgumentsGenerationTask` should be annotated with `@PathSensitive(PathSensitivity.RELATIVE)` to allow for cache relocateability.
To ensure that this task continues to be relocateable in the future, please also consider adding cache relocateability integration tests for this task: