Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
no...@gradle.com
no...@gradle.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
jb...@google.com
While making the change, I think AGP was giving me weird errors with it after adding @CacheableTask to the class. I can try changing it to see if the same error comes back.
mt...@gmail.com
Still hitting issue using AGP 7.1.2 and nav args 2.4.1.
In which AGP + nav args library combination has the issue been fixed?
Is now the sensitivity marked as PathSensitivity.RELATIVE as gradle suggested?
In which AGP + nav args library combination has the issue been fixed?
Is now the sensitivity marked as PathSensitivity.RELATIVE as gradle suggested?
ga...@migrosonline.ch
Also seeing that the current configuration still results in uncacheable tasks when using remote build cache (same versions as mentioned in the previous post). Would be really nice if we could get this working.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3bd47a4d38076ca16ac8e18e18e91c01edecfc97
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Apr 15 14:38:00 2022
Change the PathSensitive setting in ArgumentsGenTask
Changing the PathSensitivety from absolute to relative for the
navigationFiles variable in ArgumentsGenerationTasks.
RelNote: "Navigation SafeArgs now uses `PathSensitivity.RELATIVE` to
allow for cache relocateability."
Test: safe args gradle plugin test
Bug: 173420454
Change-Id: I5f67ced6e860f301678ba9f6e77683f1061ebf59
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
https://android-review.googlesource.com/2064621
Branch: androidx-main
commit 3bd47a4d38076ca16ac8e18e18e91c01edecfc97
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Apr 15 14:38:00 2022
Change the PathSensitive setting in ArgumentsGenTask
Changing the PathSensitivety from absolute to relative for the
navigationFiles variable in ArgumentsGenerationTasks.
RelNote: "Navigation SafeArgs now uses `PathSensitivity.RELATIVE` to
allow for cache relocateability."
Test: safe args gradle plugin test
Bug: 173420454
Change-Id: I5f67ced6e860f301678ba9f6e77683f1061ebf59
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
no...@gradle.com
When will this be available in a release?
Description
Version used: 2.3.1
The `navigationFiles` input to the `ArgumentsGenerationTask` should be annotated with `@PathSensitive(PathSensitivity.RELATIVE)` to allow for cache relocateability.
To ensure that this task continues to be relocateable in the future, please also consider adding cache relocateability integration tests for this task: