apksig library: ApkVerifier$Result.getV4SchemeSigners() is marked private [173422058]

Fixed

Feature Request

Status Update

No update yet.

Description

ja...@googlemail.com

created issue #1

Nov 17, 2020 08:58AM

Affected library:'com.android.tools.build', name: 'apksig', version: '4.1.1'

In class com.android.apksig.ApkVerifier$Result is the method getV4SchemeSigners() marked private which makes it impossible to use it.

The other methods getV1SchemeSigners(), getV2SchemeSigners(), getV3SchemeSigners() are all public. Please apply this also for getV4SchemeSigners() so that it is possible to retrieve the details of the v4 signature when using apksig library.

Source code reference: https://android.googlesource.com/platform/tools/apksig/+/refs/heads/master/src/main/java/com/android/apksig/ApkVerifier.java

Comments

ga...@google.com <ga...@google.com> #2Sep 9, 2022 04:20PM

Status: Duplicate of

202011194

Bingran, can you please take a look?

From the stacktrace, it seems like the issue is triggered during the native model building (com.android.build.gradle.internal.ide.v2.NativeModelBuilder.buildAll(NativeModelBuilder.kt:104), and it seems like .kts build files are used (see prepareKotlinBuildScriptModel task running).

Nick, does using:

Android Studio: 2021.3.1 Canary 7
AGP: 7.1.2
Gradle: 7.2

also fail?

ga...@google.com <ga...@google.com> #3Sep 9, 2022 06:03PM

Assigned to ga...@google.com.

I can't seem to reproduce the error now, but that may be due to project changes, or perhaps cache invalidation etc fixed it. However, given the error, perhaps there is still a bug there.

I only use build.gradle files, not kts, so any kotlin build files would be internal. However, the app uses Kotlin.

Gradle 7.2 worked with AGP 7.1.2, just 7.4 that had the problem.

ga...@google.com <ga...@google.com> #4Sep 9, 2022 06:53PM

Marked as fixed.

The error is thrown when analytics is queried in NativeModelBuilder but AnalyticsService doesn't seem to have been configured which is the reason why we get "no value available" error from AnalyticsService.reconstructProfileBuilder(AnalyticsService.kt:199. Is is not obvious why AnalyticsService is not configured in a sync build. Due to it cannot be reproduced consistently, I think we should downgrade the priority and upgrade it when we see similar issues.

Message last modified on Sep 9, 2022 06:54PM

wa...@gmail.com <wa...@gmail.com> #5Oct 14, 2022 08:06AM

I am running into this error again. Gradle 7.4 or 7.3.3, AGP 7.2.0, AS Dolphin | 2021.3.1 Beta 1. What can I try to resolve it?

ga...@google.com <ga...@google.com> #6Oct 14, 2022 09:13AM

Does it happen consistently? like every time you open the project?

Issue 173422058