Status Update
No update yet.
Comments
ga...@google.com
As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a
namespace <n>
testNamespace <tn>
where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?
ga...@google.com
Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.
ga...@google.com
OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?
wa...@gmail.com
It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.
ga...@google.com
I would consider first adding the right new value to models (as a new property) and then, to avoid Studio interpreting manifests and build configurations, just update to whatever the synced value of this new property is.
Description
Affected library:'com.android.tools.build', name: 'apksig', version: '4.1.1'
In class
com.android.apksig.ApkVerifier$Resultis the methodgetV4SchemeSigners()marked private which makes it impossible to use it.The other methods
getV1SchemeSigners(),getV2SchemeSigners(),getV3SchemeSigners()are all public. Please apply this also forgetV4SchemeSigners()so that it is possible to retrieve the details of the v4 signature when using apksig library.Source code reference:https://android.googlesource.com/platform/tools/apksig/+/refs/heads/master/src/main/java/com/android/apksig/ApkVerifier.java