apksig library: ApkVerifier$Result.getV4SchemeSigners() is marked private [173422058]

Fixed

Feature Request

Status Update

No update yet.

Description

ja...@googlemail.com

created issue #1

Nov 17, 2020 08:58AM

Affected library:'com.android.tools.build', name: 'apksig', version: '4.1.1'

In class com.android.apksig.ApkVerifier$Result is the method getV4SchemeSigners() marked private which makes it impossible to use it.

The other methods getV1SchemeSigners(), getV2SchemeSigners(), getV3SchemeSigners() are all public. Please apply this also for getV4SchemeSigners() so that it is possible to retrieve the details of the v4 signature when using apksig library.

Source code reference: https://android.googlesource.com/platform/tools/apksig/+/refs/heads/master/src/main/java/com/android/apksig/ApkVerifier.java

Comments

ga...@google.com <ga...@google.com> #2Sep 9, 2022 04:20PM

Status: Duplicate of

202011194

Is this fixed? I'm still seeing this issue with AGP 8.1.0-beta01 + Gradle 8.1

ga...@google.com <ga...@google.com> #3Sep 9, 2022 06:03PM

Assigned to ga...@google.com.

The fix has not been landed.

ga...@google.com <ga...@google.com> #4Sep 9, 2022 06:53PM

Marked as fixed.

Due to this bug in CI we hit configuration cache invalidation 100% of the time. Can we make sure the fix lands soon? And especially before 8.1.0 stable.

Message last modified on Sep 9, 2022 06:54PM

wa...@gmail.com <wa...@gmail.com> #5Oct 14, 2022 08:06AM

I cc'ed you on the CL which should be landed this week.

ga...@google.com <ga...@google.com> #6Oct 14, 2022 09:13AM

Aurimas, is this 8.1 blocking for Androidx? If not, feel free to remove the "Blocking release" label.

Issue 173422058