AppCompatTextView.setCustomSelectionActionModeCallback with null callback causes crash on Oreo [173435375]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 17, 2020 04:28AM

Component used: AppCompat Version used: appcompat-1.2.0 Devices/Android versions reproduced on: Oreo, API level 26 & 27

To reproduce:

Create AppCompatTextView and invoke setCustomSelectionActionModeCallback(null).
Long click on its text to bring up the selection action menu.
Observe crash.

This arises from the fact that AppCompatTextView.setCustomActionModeCallback accepts nullables, but internally calls to TextViewCompat.wrapCustomSelectionActionModeCallback, which requires a non-null callback.

Offending lines:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextView.java;l=446

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:core/core/src/main/java/androidx/core/widget/TextViewCompat.java;l=516

To fix this, the OreoCallback wrapping should be skipped if the callback is null.

Comments

ki...@google.com <ki...@google.com> Nov 17, 2020 02:54PM

Reassigned to al...@google.com.

te...@google.com <te...@google.com> #2Jan 22, 2021 07:24PM

FYI, this bug just bit us in Chrome (bug link only visible to Googlers):

https://bugs.chromium.org/p/chromium/issues/detail?id=1168441

al...@google.com <al...@google.com> Feb 17, 2021 09:01PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #3Apr 16, 2021 04:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 02b91b2d5a14b7161e1fc09e1f335515385f5819
Author: Alan Viverette <alanv@google.com>
Date: Mon Apr 12 14:15:46 2021

Avoid NPE when handling null custom selection action mode callback

Also ensures that get/set are symmetric by unerapping callback.

Relnote: """Avoid NPE when handling null custom selection action mode
callbacks on AppCompat-backed views."""
Test: AppCompatTextViewTest et al
Fixes: 173435375
Change-Id: I033c712ffa477853f122788f2335e7cab9a877fb

M appcompat/appcompat/src/androidTest/AndroidManifest.xml
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatAutoCompleteTextViewActivity.java
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatAutoCompleteTextViewTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatButtonTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatCheckedTextViewTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatTextViewTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/SwitchCompatTest.java
A appcompat/appcompat/src/androidTest/res/layout/appcompat_autocompletetextview_activity.xml
M appcompat/appcompat/src/androidTest/res/values/strings.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatAutoCompleteTextView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatButton.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckedTextView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEditText.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/SwitchCompat.java
D core/core/api/current.ignore
M core/core/api/restricted_current.ignore
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/widget/TextViewCompat.java

https://android-review.googlesource.com/1673613

Issue 173435375

Description

Issue summary

Comments

ki...@google.com <ki...@google.com> Nov 17, 2020 02:54PM

te...@google.com <te...@google.com> #2Jan 22, 2021 07:24PM

al...@google.com <al...@google.com> Feb 17, 2021 09:01PM

ap...@google.com <ap...@google.com> #3Apr 16, 2021 04:02PM

Add comment

Issue metadata