Feature Request: Singleton management [173726702]

Fixed

Feature Request

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Nov 21, 2020 05:17AM

DataStore Component used: All
DataStore Version used: 1.0.0-alpha-04

DataStoreFactory and PreferenceDataStoreFactory include the following warning:

The user is responsible for ensuring that there is never more than one instance of SingleProcessDataStore acting on a file at a time.

Could the factories be made responsible for returning the same instance if they've already created one, so the consuming app doesn't need to manage that themselves?

Comments

ap...@google.com <ap...@google.com> #2Feb 17, 2021 01:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit 2099e20d0af61318ec59b5c6391498304979e024
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 14:38:14 2023

Migrate paging-testing to PagingSourceFactory

Migrate existing usages of lambda type () -> PagingSource<Key, Value> to concrete PagingSourceFactory<Key, Value> type

Test: ./gradlew paging:paging-testing:cC
Bug: 280655188
Relnote: "Migrated paging-testing's use of lambda type () -> PagingSource<Key, Value> to type PagingSourceFactory<Key, Value>."
Change-Id: I4a95067989fabf8258a3392007dbf8abd35d8efa

M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt

https://android-review.googlesource.com/2579311

ro...@google.com <ro...@google.com> Feb 17, 2021 09:18PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Feb 23, 2021 05:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit f06753ed29d67623b4061cb222717948d0a37ef7
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 13:16:53 2023

Add PagingSourceFactory interface

This functional interface allows creating a PagingSourceFactory by passing in a lambda that returns a PagingSource, or by creating a class that extends this interface. The factory can be passed into Pager as the pagingSourceFactory.

Test: ./gradlew paging:paging-common:test
Bug: 280655188
Relnote: "Added a new PagingSourceFactory functional interface. Override the invoke() method with an implementation that returns a new instance of PagingSource. This factory can be used to instantiate a Pager."
Change-Id: I3316590a0d667566edeb40d4e99e005cd6cee3ac

M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/main/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
A paging/paging-common/src/main/kotlin/androidx/paging/PagingSourceFactory.kt

https://android-review.googlesource.com/2579310

ru...@gmail.com <ru...@gmail.com> #4Feb 25, 2021 01:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 967c97f18d7f2a717222b09be6227f0f7dabb323
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 13:06:24 2023

Update documentation for asPagingSourceFactory API

Kdocs updated to reflec the API's migration from returning a lambda to returning a Class.

Test: n/a
Bug: 280655188
Change-Id: Ib3f9b5c9215ba9e5ee38d6b192e9858bbe080346

M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt

https://android-review.googlesource.com/2580094

ro...@google.com <ro...@google.com> #5Feb 25, 2021 06:17AM

Project: platform/frameworks/support
Branch: androidx-main

commit 59e0f757ba85b81b800e6fb0d60dd25dd88bee54
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 12:52:34 2023

Expand asPagingSourceFactory API to singe list

In addition to Flow<List<Value>>.asPagingSourceFactory API, we added a List<Value>.asPagingSourceFactory. All PagingSoruces produced by this new API will load from the exact same static list of data. It supports multi-generational operations such as refresh, but it does not support any updates to the source data. Because it operates on a static list, collection is not required which removes the requirement for a coroutineScope.

Test: ./gradlew paging:paging-testing:test
Bug: 280655188
Relnote: "Added new API List<Value>.asPagingSourceFactory to get a factory that creates PagingSource instances that loads from the immutable list of data."
Change-Id: Id34d1361119413d0c19a054a2e23dd26241faa6f

M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt

https://android-review.googlesource.com/2580093

jd...@xooloo.com <jd...@xooloo.com> #6Feb 25, 2021 10:23AM

Fixed internally and will be available in paging 3.2.0-alpha06.

jd...@xooloo.com <jd...@xooloo.com> #7Feb 25, 2021 10:38AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.paging:paging-common:3.2.0-alpha06
androidx.paging:paging-testing:3.2.0-alpha06

ro...@google.com <ro...@google.com> #8Feb 26, 2021 04:08PM

Status: In Progress (Accepted) (reopened)

Thanks for reporting - we are working on a fix for the migrations for next release.

ap...@google.com <ap...@google.com> #9Feb 26, 2021 07:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit b64da89bd9caa4492b296a701e08d3d6fb7f2e52
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Feb 26 09:51:28 2021

Change migrations param to migrationProducers param for datastore property delegate since you may need context to create a sp migration for example.

Test: See new tests
Relnote: You can now add a migration that depends on context to your `dataStore` and `preferencesDataStore` property delegate.
Bug: 173726702
Change-Id: I4ef69b0eed544cde4f05cdee9e885d36af0f4abb

M datastore/datastore-preferences-rxjava2/api/current.txt
M datastore/datastore-preferences-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-rxjava2/api/restricted_current.txt
M datastore/datastore-preferences-rxjava2/src/androidTest/java/androidx/datastore/preferences/rxjava2/RxPreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences-rxjava2/src/main/java/androidx/datastore/preferences/rxjava2/RxPreferenceDataStoreDelegate.kt
M datastore/datastore-preferences-rxjava3/api/current.txt
M datastore/datastore-preferences-rxjava3/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-rxjava3/api/restricted_current.txt
M datastore/datastore-preferences-rxjava3/src/androidTest/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences-rxjava3/src/main/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreDelegate.kt
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/PreferenceDataStoreDelegate.kt
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreDelegateTest.kt
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreDelegate.kt
M datastore/datastore-rxjava3/api/current.txt
M datastore/datastore-rxjava3/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava3/api/restricted_current.txt
M datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxDataStoreDelegateTest.kt
M datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStoreDelegate.kt
M datastore/datastore/api/current.txt
M datastore/datastore/api/public_plus_experimental_current.txt
M datastore/datastore/api/restricted_current.txt
M datastore/datastore/src/androidTest/java/androidx/datastore/DataStoreDelegateTest.kt
M datastore/datastore/src/androidTest/java/androidx/datastore/migrations/SharedPreferencesMigrationTest.kt
M datastore/datastore/src/main/java/androidx/datastore/DataStoreDelegate.kt

https://android-review.googlesource.com/1606566

ro...@google.com <ro...@google.com> Mar 5, 2021 07:19PM