Feature Request: Singleton management [173726702]

Fixed

Feature Request

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Nov 21, 2020 05:17AM

DataStore Component used: All
DataStore Version used: 1.0.0-alpha-04

DataStoreFactory and PreferenceDataStoreFactory include the following warning:

The user is responsible for ensuring that there is never more than one instance of SingleProcessDataStore acting on a file at a time.

Could the factories be made responsible for returning the same instance if they've already created one, so the consuming app doesn't need to manage that themselves?

Comments

ap...@google.com <ap...@google.com> #2Feb 17, 2021 01:23AM

The traces that are generated are correctly being parsed by https://profiler.firefox.com.

Attached is an example trace.

ro...@google.com <ro...@google.com> Feb 17, 2021 09:18PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Feb 23, 2021 05:22PM

That file works for me as well, something is different about the ones I captured (likely device on which it was captured). Filed b/332330752

@Leland - you should be able to workaround not getting usable macro traces by either trying a different device/OS image, or viewing the traces in https://profiler.firefox.com

ru...@gmail.com <ru...@gmail.com> #4Feb 25, 2021 01:46AM

Reassigning to the default assignee given it looks like a Studio issue. Will wait for activity on the blocking bug.

ro...@google.com <ro...@google.com> #5Feb 25, 2021 06:17AM

Hi. I've received your bug, you didn't specify what to wait for so I will wait for

b/332330752

to be resolved and then assign the bug to androidx-benchmark-issues@google.com.

Bugjuggler:

b/332330752

-> assigned to androidx-benchmark-issues@google.com

jd...@xooloo.com <jd...@xooloo.com> #6Feb 25, 2021 10:23AM

As discused in b/332330752, this is an issue with how we wait for method traces to flush in macrobenchmark.

Working on a fix.

jd...@xooloo.com <jd...@xooloo.com> #7Feb 25, 2021 10:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8f2ba6a5469f67b7e385878d704f97bde22419ce
Author: Chris Craik <ccraik@google.com>
Date: Mon Apr 08 14:49:54 2024

Fix macrobench method tracing flush on slower devices

Fixes: 329904950
Test: Enabled method tracing in SmallListStartupBenchmark
Relnote: "Fixed method traces flush in macrobench, so that method
traces are complete even on slower devices."

Change-Id: I6349a48dca4116ac9b481882395ee630785f6181

M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt

https://android-review.googlesource.com/3031941

ro...@google.com <ro...@google.com> #8Feb 26, 2021 04:08PM

Status: In Progress (Accepted) (reopened)

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.3.0-alpha03
androidx.benchmark:benchmark-macro:1.3.0-alpha03

ap...@google.com <ap...@google.com> #9Feb 26, 2021 07:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit b64da89bd9caa4492b296a701e08d3d6fb7f2e52
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Feb 26 09:51:28 2021

Change migrations param to migrationProducers param for datastore property delegate since you may need context to create a sp migration for example.

Test: See new tests
Relnote: You can now add a migration that depends on context to your `dataStore` and `preferencesDataStore` property delegate.
Bug: 173726702
Change-Id: I4ef69b0eed544cde4f05cdee9e885d36af0f4abb

M datastore/datastore-preferences-rxjava2/api/current.txt
M datastore/datastore-preferences-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-rxjava2/api/restricted_current.txt
M datastore/datastore-preferences-rxjava2/src/androidTest/java/androidx/datastore/preferences/rxjava2/RxPreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences-rxjava2/src/main/java/androidx/datastore/preferences/rxjava2/RxPreferenceDataStoreDelegate.kt
M datastore/datastore-preferences-rxjava3/api/current.txt
M datastore/datastore-preferences-rxjava3/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-rxjava3/api/restricted_current.txt
M datastore/datastore-preferences-rxjava3/src/androidTest/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences-rxjava3/src/main/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreDelegate.kt
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreDelegateTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/PreferenceDataStoreDelegate.kt
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreDelegateTest.kt
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreDelegate.kt
M datastore/datastore-rxjava3/api/current.txt
M datastore/datastore-rxjava3/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava3/api/restricted_current.txt
M datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxDataStoreDelegateTest.kt
M datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStoreDelegate.kt
M datastore/datastore/api/current.txt
M datastore/datastore/api/public_plus_experimental_current.txt
M datastore/datastore/api/restricted_current.txt
M datastore/datastore/src/androidTest/java/androidx/datastore/DataStoreDelegateTest.kt
M datastore/datastore/src/androidTest/java/androidx/datastore/migrations/SharedPreferencesMigrationTest.kt
M datastore/datastore/src/main/java/androidx/datastore/DataStoreDelegate.kt

https://android-review.googlesource.com/1606566

ro...@google.com <ro...@google.com> Mar 5, 2021 07:19PM