ObservableWatchData has a protected constructor [173802666]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Nov 20, 2020 07:02PM

ObservableWatchData has a protected constructor, that is anti-pattern (s.android.com/api-guidelines##public-fields), additionally, it has internal property, that leaks through the protected constructor. Please address this.

Comments

se...@google.com <se...@google.com> #2Nov 20, 2020 07:36PM

Thanks, we're looking into it.

au...@google.com <au...@google.com> #3Nov 20, 2020 10:54PM

Thanks for fixing it in zero time. This tells me a lot about the quality of your
work.See also in:

http://gaengine.blogspot.com/2009/09/google-maps-api-v3-part-ii.html

jn...@google.com <jn...@google.com> Nov 24, 2020 09:05AM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #4Nov 24, 2020 10:06AM

I find the idea of protected being an anti pattern to be rather surprising and probably a mistake. Anyway this can be made internal...

ap...@google.com <ap...@google.com> #5Nov 24, 2020 01:46PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0dc04546607a19d39b3d547b1e008c3020a36c3d
Author: Alex Clarke <alexclarke@google.com>
Date: Tue Nov 24 10:24:13 2020

Make ObservableWatchData's constructor internal

Bug: 173802666
Test: Presubmit
Relnote: ObservableWatchData's constructor is now internal.
Change-Id: I301215475e08c10a8cb97095638b235d664bcfcb

M wear/wear-watchface/api/current.txt
M wear/wear-watchface/api/public_plus_experimental_current.txt
M wear/wear-watchface/api/restricted_current.txt
M wear/wear-watchface/src/main/java/androidx/wear/watchface/ObservableWatchData.kt

https://android-review.googlesource.com/1508337

al...@google.com <al...@google.com> Nov 24, 2020 02:28PM

Marked as fixed.

Issue 173802666