OngoingActivityStatus has a hidden abstract method [173803230]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Nov 20, 2020 07:09PM

OngoingActivityStatus has a hidden abstract method. It is a public abstract class with a public constructor that has a hidden abstract method that cannot be extended by the external users. Do we want OngoingActivityStatus to have a hidden constructor or should extend(Bundle) be public?

Comments

au...@google.com <au...@google.com> #2Nov 20, 2020 07:12PM

Thanks, we're looking into it.

jn...@google.com <jn...@google.com> #3Nov 24, 2020 09:07AM

Reassigned to ss...@google.com.

Thanks for fixing it in zero time. This tells me a lot about the quality of your
work.See also in:

http://gaengine.blogspot.com/2009/09/google-maps-api-v3-part-ii.html

ss...@google.com <ss...@google.com> #4Nov 30, 2020 01:21PM

Reassigned to al...@google.com.

Method was removed.

al...@google.com <al...@google.com> #5Nov 30, 2020 01:52PM

Re UserStyleSetting I'm not sure I see the problem, it's a sealed class, this won't trip devs up.

Renderer.kt isn't currently sealed but probably should be and the same argument would apply.

ap...@google.com <ap...@google.com> #6Dec 1, 2020 10:30AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b053d71fb7188ccaef8fb5a871a8dec57f05aa3b
Author: Alex Clarke <alexclarke@google.com>
Date: Mon Nov 30 15:17:09 2020

WatchFace Make Renderer a sealed class

Bug: 173803230
Test: Presubmit
Relnote: Renderer is now a sealed class. This means CanvasRenderer and GlesRenderer are now inner classes of Renderer.
Change-Id: Iab5d4cf05f02a2ed3a47729c32fac6b6e6cf23dc

M wear/wear-watchface-complications-rendering/src/test/java/androidx/wear/watchface/complications/rendering/ComplicationDrawableTest.java
M wear/wear-watchface/api/current.txt
M wear/wear-watchface/api/public_plus_experimental_current.txt
M wear/wear-watchface/api/restricted_current.txt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasAnalogWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasDigitalWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleOpenGLWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/KDocExampleWatchFace.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/CanvasRenderer.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/GlesRenderer.kt
M wear/wear-watchface/src/main/java/androidx/wear/watchface/Renderer.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/TestCommon.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/ui/WatchFaceConfigUiTest.kt

https://android-review.googlesource.com/1512984

al...@google.com <al...@google.com> Dec 2, 2020 04:33PM

Marked as fixed.

Issue 173803230