Fixed
Status Update
Comments
au...@google.com <au...@google.com> #2
Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:
<transition xmlns:android="http://schemas.android.com/apk/res/android " >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="http://schemas.android.com/apk/res/android "
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
jn...@google.com <jn...@google.com> #3
Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)
ss...@google.com <ss...@google.com> #4
al...@google.com <al...@google.com> #5
Re UserStyleSetting I'm not sure I see the problem, it's a sealed class, this won't trip devs up.
Renderer.kt isn't currently sealed but probably should be and the same argument would apply.
Renderer.kt isn't currently sealed but probably should be and the same argument would apply.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b053d71fb7188ccaef8fb5a871a8dec57f05aa3b
Author: Alex Clarke <alexclarke@google.com>
Date: Mon Nov 30 15:17:09 2020
WatchFace Make Renderer a sealed class
Bug: 173803230
Test: Presubmit
Relnote: Renderer is now a sealed class. This means CanvasRenderer and GlesRenderer are now inner classes of Renderer.
Change-Id: Iab5d4cf05f02a2ed3a47729c32fac6b6e6cf23dc
M wear/wear-watchface-complications-rendering/src/test/java/androidx/wear/watchface/complications/rendering/ComplicationDrawableTest.java
M wear/wear-watchface/api/current.txt
M wear/wear-watchface/api/public_plus_experimental_current.txt
M wear/wear-watchface/api/restricted_current.txt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasAnalogWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasDigitalWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleOpenGLWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/KDocExampleWatchFace.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/CanvasRenderer.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/GlesRenderer.kt
M wear/wear-watchface/src/main/java/androidx/wear/watchface/Renderer.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/TestCommon.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/ui/WatchFaceConfigUiTest.kt
https://android-review.googlesource.com/1512984
Branch: androidx-master-dev
commit b053d71fb7188ccaef8fb5a871a8dec57f05aa3b
Author: Alex Clarke <alexclarke@google.com>
Date: Mon Nov 30 15:17:09 2020
WatchFace Make Renderer a sealed class
Bug: 173803230
Test: Presubmit
Relnote: Renderer is now a sealed class. This means CanvasRenderer and GlesRenderer are now inner classes of Renderer.
Change-Id: Iab5d4cf05f02a2ed3a47729c32fac6b6e6cf23dc
M wear/wear-watchface-complications-rendering/src/test/java/androidx/wear/watchface/complications/rendering/ComplicationDrawableTest.java
M wear/wear-watchface/api/current.txt
M wear/wear-watchface/api/public_plus_experimental_current.txt
M wear/wear-watchface/api/restricted_current.txt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasAnalogWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleCanvasDigitalWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/ExampleOpenGLWatchFaceService.kt
M wear/wear-watchface/samples/src/main/java/androidx/wear/watchface/samples/KDocExampleWatchFace.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/CanvasRenderer.kt
D wear/wear-watchface/src/main/java/androidx/wear/watchface/GlesRenderer.kt
M wear/wear-watchface/src/main/java/androidx/wear/watchface/Renderer.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/TestCommon.kt
M wear/wear-watchface/src/test/java/androidx/wear/watchface/ui/WatchFaceConfigUiTest.kt
Description
OngoingActivityStatus
has a hidden abstract method. It is a public abstract class with a public constructor that has a hidden abstract method that cannot be extended by the external users. Do we wantOngoingActivityStatus
to have a hidden constructor or shouldextend(Bundle)
be public?