ViewCompat and AppCompatEditText should provide an API to facilitate insertion of non-text content [173814913]

Fixed

Feature Request

Status Update

No update yet.

Description

du...@google.com

created issue #1

Nov 20, 2020 09:33PM

Images and other rich content are supported by the clipboard and by the IME. However, in order to handle insertion of non-text content an app currently needs to implement multiple APIs:
* TextView.onTextContextMenuItem to handle insertion from the clipboard (paste action in the long-press toolbar menu)
* TextView.onCreateInputConnection to handle insertion from the IME

ViewCompat and AppCompatEditText should provide a single, unified listener API for apps to be able to accept content insertion regardless of the specific UI through which it comes in.

Comments

al...@google.com <al...@google.com> Nov 30, 2020 04:45PM

Reassigned to si...@google.com.

du...@google.com <du...@google.com> #2Nov 30, 2020 08:28PM

Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:

<transition xmlns:android="

http://schemas.android.com/apk/res/android" >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>

where blue/green drawables look like this:

<shape
xmlns:android="

http://schemas.android.com/apk/res/android"
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>

Then added this test:

@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);

Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}

It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.

ap...@google.com <ap...@google.com> #3Dec 4, 2020 08:53PM

Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)

ap...@google.com <ap...@google.com> #4Dec 8, 2020 06:33PM

https://android-review.googlesource.com/c/platform/frameworks/support/+/960032 with the test. Closing as not reproducible. If this is still happening for you, we'd need to see either a test (same as in this CL) or a small, standalone sample project that reproduces this issue on v17 (or other) devices.

si...@google.com <si...@google.com> Dec 8, 2020 07:44PM

Reassigned to du...@google.com.

du...@google.com <du...@google.com> Dec 8, 2020 08:18PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jan 28, 2021 02:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit fa9a50f143d3e751875066882adc7160e73a6800
Author: Nikita Dubrovsky <dubrovsky@google.com>
Date: Wed Dec 02 11:47:29 2020

Test app for OnReceiveContentListener

Bug: 173814913
Test: Manually tested inserting an image via paste, drop, and from IME
Change-Id: I3cb2eb11dcf14e2172c3ef78abc4b8f7c463f2a9

A appcompat/integration-tests/receive-content-testapp/build.gradle
A appcompat/integration-tests/receive-content-testapp/lint-baseline.xml
A appcompat/integration-tests/receive-content-testapp/src/main/AndroidManifest.xml
A appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/Logcat.java
A appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MainActivity.java
A appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MyExecutors.java
A appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MyReceiver.java
A appcompat/integration-tests/receive-content-testapp/src/main/res/layout/activity_main.xml
A appcompat/integration-tests/receive-content-testapp/src/main/res/values/strings.xml
A appcompat/integration-tests/receive-content-testapp/src/main/res/values/styles.xml
M settings.gradle

https://android-review.googlesource.com/1555561

jd...@gmail.com <jd...@gmail.com> #6May 11, 2021 08:51AM

Apk