Downloadable fonts are not supported in Compose [174162090]

Fixed

Feature

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Nov 25, 2020 03:22PM

Currently we can not use downloadable fonts in Compose. It would be great if we could use them to reduce APK size.

Comments

si...@google.com <si...@google.com> #2Nov 25, 2020 03:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

Message last modified on Nov 25, 2020 03:25PM

ch...@gmail.com <ch...@gmail.com> #3Nov 25, 2020 03:32PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

si...@google.com <si...@google.com> #4Nov 25, 2020 03:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

co...@protonmail.com <co...@protonmail.com> #5Dec 17, 2020 05:45AM

Wait, so downloadable fonts aren't supported in compose, BUT we can use custom fonts by packaging them in the apk?

si...@google.com <si...@google.com> #6Apr 14, 2021 06:16PM

re:comment#5

you can use android regular downloadable fonts (~Resources.getFont), grab the Typeface and pass into Compose.

cm...@gmail.com <cm...@gmail.com> #7Jun 17, 2021 06:27PM

Hi!

I have a question about implementing the above workaround. We're using downloadable fonts via xml, as outlined here:

https://developer.android.com/guide/topics/ui/look-and-feel/downloadable-fonts#using-downloadable-fonts-as-resources

As far as I can tell, unlike with bundled fonts, wherein multiple font declarations can be nested under a single font family tag, when working with downloadable fonts as outlined in the link, each weight of font is declared in its own fontFamily tag in a separate xml file (i.e. we have 3 font files with top level <font-family> tags to request download of the 3 different font weights).

This seems problematic when trying to get these various bold, medium, etc weights into a Compose Typography object (to provide to MaterialTheme) because the only exposed API I see for FontFamily takes only one typeface, not multiples:

fun FontFamily(typeface: Typeface): FontFamily = LoadedFontFamily(typeface)

In the context of the Downloadable Fonts workaround, is there a way to provide multiple font weights to FontFamily as is done in the Compose samples with bundled fonts?
@Sampled
@Composable
fun CustomFontFamilySample() {
val fontFamily = FontFamily(
Font(
resId = R.font.my_font_400_regular,
weight = FontWeight.W400,
style = FontStyle.Normal
),
Font(
resId = R.font.my_font_400_italic,
weight = FontWeight.W400,
style = FontStyle.Italic
)
)
Text(text = "Demo Text", fontFamily = fontFamily)
}

Thanks!

ha...@google.com <ha...@google.com> #8Jun 18, 2021 07:59AM

Did some investigation.

It turned out that fontWeight and fontStyle doesn't work for the workaround mentioned in #2.(Our font matcher ignored the input fontWeight/fontStyle when the FontFamily is constructed from an Android Typeface)
And we currently don't have any way to create a Font from a downloadable font xml. And as a result, equivalent of the example in #7 is not achievable with current API.

One thing I'm unsure is that Font(resId: Int, weight: FontWeight, style: fontStyle) ideally should work for downloadable font xml. But it crashes every time when I attempt to do so.(The underlying api used is Resource.getFont(), and according to this article it should work.) Siyamed@ do you have any idea of what could happen here?

si...@google.com <si...@google.com> #9Jun 18, 2021 05:10PM

Sorry, let me understand better:

current fonts xml does not allow multiple font weights already.
this requires 1 font xml definition per weight
from 1 xml definition there can be 1 Typeface for that weight
Compose accepts 1 Typeface that can be converted into a FontFamily.

Based on those, the current state requires

define 1 xml per weight
use regular downloadable fonts to download the font and get the Typeface using Resources#getFont (async version)
From that Typeface create a FontFamily and assign to the Text
If the text needs to show different weights, change the textStyle to use the correct Typeface.

Currently we do not have APIs for Downloadable fonts in Compose Font(resId: Int, weight: FontWeight, style: fontStyle) is not the right way to use it.

se...@google.com <se...@google.com> Jul 19, 2021 04:53PM

Reassigned to se...@google.com.

ap...@google.com <ap...@google.com> #10Jan 28, 2022 05:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66412d57cf31abe84a02c629a9ff6c6600b663df
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jan 27 14:25:42 2022

API stability for Desktop FontLoader

Returns load to returning SkTypeface.

createFontFamilyResolver(Font.ResourceLoader) becomes expect/actual to
allow platfrom difference in behavior.

Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true --no-daemon
Relnote: "Internal generated kt class rename"

Bug:

Issue 174162090

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Nov 25, 2020 03:25PM

ch...@gmail.com <ch...@gmail.com> #3Nov 25, 2020 03:32PM

si...@google.com <si...@google.com> #4Nov 25, 2020 03:33PM

co...@protonmail.com <co...@protonmail.com> #5Dec 17, 2020 05:45AM

si...@google.com <si...@google.com> #6Apr 14, 2021 06:16PM

cm...@gmail.com <cm...@gmail.com> #7Jun 17, 2021 06:27PM

ha...@google.com <ha...@google.com> #8Jun 18, 2021 07:59AM

si...@google.com <si...@google.com> #9Jun 18, 2021 05:10PM

se...@google.com <se...@google.com> Jul 19, 2021 04:53PM

ap...@google.com <ap...@google.com> #10Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #11Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #12Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #13Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #14Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #15Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #16Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #17Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #18Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #19Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #20Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #21Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #22Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #23Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #24Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #25Jan 28, 2022 05:32PM

ap...@google.com <ap...@google.com> #26Feb 16, 2022 09:13PM

ap...@google.com <ap...@google.com> #27Feb 16, 2022 09:13PM

ni...@google.com <ni...@google.com> #28Apr 7, 2022 07:51PM

se...@google.com <se...@google.com> Apr 8, 2022 10:16PM

Add comment

Issue metadata