Downloadable fonts are not supported in Compose [174162090]

Fixed

Feature

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Nov 25, 2020 03:22PM

Currently we can not use downloadable fonts in Compose. It would be great if we could use them to reduce APK size.

Comments

si...@google.com <si...@google.com> #2Nov 25, 2020 03:25PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

Message last modified on Nov 25, 2020 03:25PM

ch...@gmail.com <ch...@gmail.com> #3Nov 25, 2020 03:32PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

si...@google.com <si...@google.com> #4Nov 25, 2020 03:33PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

co...@protonmail.com <co...@protonmail.com> #5Dec 17, 2020 05:45AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

si...@google.com <si...@google.com> #6Apr 14, 2021 06:16PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

cm...@gmail.com <cm...@gmail.com> #7Jun 17, 2021 06:27PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

ha...@google.com <ha...@google.com> #8Jun 18, 2021 07:59AM

Yes, this fix is planned to be included in a future 1.7.x release.

si...@google.com <si...@google.com> #9Jun 18, 2021 05:10PM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

se...@google.com <se...@google.com> Jul 19, 2021 04:53PM

Reassigned to se...@google.com.

ap...@google.com <ap...@google.com> #10Jan 28, 2022 05:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66412d57cf31abe84a02c629a9ff6c6600b663df
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Jan 27 14:25:42 2022

API stability for Desktop FontLoader

Returns load to returning SkTypeface.

createFontFamilyResolver(Font.ResourceLoader) becomes expect/actual to
allow platfrom difference in behavior.

Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true --no-daemon
Relnote: "Internal generated kt class rename"

Bug:

Issue 174162090

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Nov 25, 2020 03:25PM

ch...@gmail.com <ch...@gmail.com> #3Nov 25, 2020 03:32PM

si...@google.com <si...@google.com> #4Nov 25, 2020 03:33PM

co...@protonmail.com <co...@protonmail.com> #5Dec 17, 2020 05:45AM

si...@google.com <si...@google.com> #6Apr 14, 2021 06:16PM

cm...@gmail.com <cm...@gmail.com> #7Jun 17, 2021 06:27PM

ha...@google.com <ha...@google.com> #8Jun 18, 2021 07:59AM

si...@google.com <si...@google.com> #9Jun 18, 2021 05:10PM

se...@google.com <se...@google.com> Jul 19, 2021 04:53PM

ap...@google.com <ap...@google.com> #10Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #11Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #12Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #13Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #14Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #15Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #16Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #17Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #18Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #19Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #20Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #21Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #22Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #23Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #24Jan 28, 2022 05:31PM

ap...@google.com <ap...@google.com> #25Jan 28, 2022 05:32PM

ap...@google.com <ap...@google.com> #26Feb 16, 2022 09:13PM

ap...@google.com <ap...@google.com> #27Feb 16, 2022 09:13PM

ni...@google.com <ni...@google.com> #28Apr 7, 2022 07:51PM

se...@google.com <se...@google.com> Apr 8, 2022 10:16PM

Add comment

Issue metadata