Pressing the back button when the text selection handle bars are shown should cause the selection bars to be dismissed [174173645]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Nov 24, 2020 11:46PM

With traditional views, if you have the keyboard open with text selection handle bars being shown, the following happens when you press the back button:

First time, the selection handlebars disappear.
Second time, the keyboard dismisses.
Third time, the default system back button behavior is executed.

Ideally, Compose would follow this same behavior automatically as well, if possible.

I attached two videos to the report. One shows the (ideal/correct) behavior with traditional views. The second shows the (current/incorrect) behavior with Compose as of today (1.0.0-alpha08 snapshot).

selection-back-button-views.mp4

1.2 MB

Download

selection-back-button-compose.mp4

762 KB

Download

Comments

si...@google.com <si...@google.com> Apr 1, 2021 06:17PM

Reassigned to qq...@google.com.

qq...@google.com <qq...@google.com> #2Apr 29, 2021 01:42AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

gdoc_back.mp4

3.9 MB

Download

gmail_back.mp4

3.6 MB

Download

message_back.mp4

3.6 MB

Download

si...@google.com <si...@google.com> Jun 11, 2021 06:13PM

Reassigned to an...@google.com.

se...@google.com <se...@google.com> #3Jul 14, 2021 12:08AM

Reassigned to se...@google.com.

Confirming the behavior is (keyboard, selection, back) on Android S. Checking some more

se...@google.com <se...@google.com> #4Jul 14, 2021 12:12AM

One big change is that clearing selection is not done by back in the Compose implementation.

Exploring how to implement this in compose:foundation without adding activity-compose.

se...@google.com <se...@google.com> #5Jul 14, 2021 12:22AM

https://android-review.googlesource.com/c/platform/frameworks/support/+/1765368

Reviewing alternative implementations.

se...@google.com <se...@google.com> #6Jul 14, 2021 05:16PM

Here's the framework code to accomplish this

https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/widget/TextView.java;l=8221

se...@google.com <se...@google.com> #7Jul 15, 2021 08:20PM

Comment has been deleted.

Message last modified on Jul 15, 2021 08:21PM

se...@google.com <se...@google.com> #8Jul 15, 2021 08:22PM

Thanks for the report, super helpful!

A patch is coming for CoreTextField shortly, investigating the selection behavior for Text as well.

se...@google.com <se...@google.com> #9Jul 15, 2021 10:11PM

Marked as fixed.

Checking TextView, it looks like the non-editable selection doesn't need cleared on back. Thanks for report!

ap...@google.com <ap...@google.com> #10Jul 16, 2021 05:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit de1034714344ecdfc22f94a1244ab076cbc066b1
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Jul 13 17:12:50 2021

When text is selected in compose, back deselects

Matches Android platfrom behavior of intercepting back key up to dismiss
selection popups and deselect text.

Bug:

b/174173645

Test: new unit tests
Relnote: "TextField now clears selection when back button is pressed,
which matches Android EditText behavior."

Change-Id: I3ca164d09ee6d82f292aacfd2df0af05643cb1aa

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldSelectionOnBackTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/KeyEventHelpersTest.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.kt
A compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.desktop.kt

https://android-review.googlesource.com/1765368

Issue 174173645

Description

Issue summary

Comments

si...@google.com <si...@google.com> Apr 1, 2021 06:17PM

qq...@google.com <qq...@google.com> #2Apr 29, 2021 01:42AM

si...@google.com <si...@google.com> Jun 11, 2021 06:13PM

se...@google.com <se...@google.com> #3Jul 14, 2021 12:08AM

se...@google.com <se...@google.com> #4Jul 14, 2021 12:12AM

se...@google.com <se...@google.com> #5Jul 14, 2021 12:22AM

se...@google.com <se...@google.com> #6Jul 14, 2021 05:16PM

se...@google.com <se...@google.com> #7Jul 15, 2021 08:20PM

se...@google.com <se...@google.com> #8Jul 15, 2021 08:22PM

se...@google.com <se...@google.com> #9Jul 15, 2021 10:11PM

ap...@google.com <ap...@google.com> #10Jul 16, 2021 05:24PM

Add comment

Issue metadata