Pressing the back button when the text selection handle bars are shown should cause the selection bars to be dismissed [174173645]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Nov 24, 2020 11:46PM

With traditional views, if you have the keyboard open with text selection handle bars being shown, the following happens when you press the back button:

First time, the selection handlebars disappear.
Second time, the keyboard dismisses.
Third time, the default system back button behavior is executed.

Ideally, Compose would follow this same behavior automatically as well, if possible.

I attached two videos to the report. One shows the (ideal/correct) behavior with traditional views. The second shows the (current/incorrect) behavior with Compose as of today (1.0.0-alpha08 snapshot).

selection-back-button-views.mp4

1.2 MB

Download

selection-back-button-compose.mp4

762 KB

Download

Comments

si...@google.com <si...@google.com> Apr 1, 2021 06:17PM

Reassigned to qq...@google.com.

qq...@google.com <qq...@google.com> #2Apr 29, 2021 01:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

gdoc_back.mp4

3.9 MB

Download

gmail_back.mp4

3.6 MB

Download

message_back.mp4

3.6 MB

Download

si...@google.com <si...@google.com> Jun 11, 2021 06:13PM

Reassigned to an...@google.com.

se...@google.com <se...@google.com> #3Jul 14, 2021 12:08AM

Reassigned to se...@google.com.

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

se...@google.com <se...@google.com> #4Jul 14, 2021 12:12AM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

se...@google.com <se...@google.com> #5Jul 14, 2021 12:22AM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

se...@google.com <se...@google.com> #6Jul 14, 2021 05:16PM

Bugjuggler: wait until 2022-03-23

se...@google.com <se...@google.com> #7Jul 15, 2021 08:20PM

Comment has been deleted.

Message last modified on Jul 15, 2021 08:21PM

se...@google.com <se...@google.com> #8Jul 15, 2021 08:22PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

se...@google.com <se...@google.com> #9Jul 15, 2021 10:11PM

Marked as fixed.

Abandon. The owning team had no plans to release a replacement library.

ap...@google.com <ap...@google.com> #10Jul 16, 2021 05:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit de1034714344ecdfc22f94a1244ab076cbc066b1
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Jul 13 17:12:50 2021

When text is selected in compose, back deselects

Matches Android platfrom behavior of intercepting back key up to dismiss
selection popups and deselect text.

Bug:

b/174173645

Test: new unit tests
Relnote: "TextField now clears selection when back button is pressed,
which matches Android EditText behavior."

Change-Id: I3ca164d09ee6d82f292aacfd2df0af05643cb1aa

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldSelectionOnBackTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/KeyEventHelpersTest.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.kt
A compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.desktop.kt

https://android-review.googlesource.com/1765368

Issue 174173645

Description

Issue summary

Comments

si...@google.com <si...@google.com> Apr 1, 2021 06:17PM

qq...@google.com <qq...@google.com> #2Apr 29, 2021 01:42AM

si...@google.com <si...@google.com> Jun 11, 2021 06:13PM

se...@google.com <se...@google.com> #3Jul 14, 2021 12:08AM

se...@google.com <se...@google.com> #4Jul 14, 2021 12:12AM

se...@google.com <se...@google.com> #5Jul 14, 2021 12:22AM

se...@google.com <se...@google.com> #6Jul 14, 2021 05:16PM

se...@google.com <se...@google.com> #7Jul 15, 2021 08:20PM

se...@google.com <se...@google.com> #8Jul 15, 2021 08:22PM

se...@google.com <se...@google.com> #9Jul 15, 2021 10:11PM

ap...@google.com <ap...@google.com> #10Jul 16, 2021 05:24PM

Add comment

Issue metadata