Add checkFlagsArgument() to androidx.core.util.Preconditions [174181100]

Fixed

Feature Request

Status Update

No update yet.

Description

du...@google.com

created issue #1

Nov 24, 2020 11:30PM

Preconditions.checkFlagsArgument() is useful for validating that a flag argument is within the set of allowed flags.

Existing function in the SDK (internal util):

https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/com/android/internal/util/Preconditions.java;l=196;drc=5d123b67756dffcfdebdb936ab2de2b29c799321

Comments

du...@google.com <du...@google.com> #2Nov 24, 2020 11:35PM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

al...@google.com <al...@google.com> Nov 30, 2020 06:09PM

Reassigned to du...@google.com.

ap...@google.com <ap...@google.com> #3Nov 30, 2020 06:10PM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

al...@google.com <al...@google.com> Nov 30, 2020 08:52PM

Marked as fixed.

Issue 174181100

Description

Issue summary

Comments

du...@google.com <du...@google.com> #2Nov 24, 2020 11:35PM

al...@google.com <al...@google.com> Nov 30, 2020 06:09PM

ap...@google.com <ap...@google.com> #3Nov 30, 2020 06:10PM

al...@google.com <al...@google.com> Nov 30, 2020 08:52PM

Add comment

Issue metadata