IssueTracker

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.5.0-alpha02

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.tv:tv-material:1.0.0-alpha07

Is there any planned release for this fix? Should we hope it for 1.2.0 alpha 3?

No updates yet in this regard, we will let you know when there's a known release this will be provided in.

This is an unrelated problem to the nested scroll in this ticket. In your case error message indicates that you are on the old compose version, newer error message explain how to fix it. Right now it says

Vertically scrollable component was measured with an infinity maximum height " +
                "constraints, which is disallowed. One of the common reasons is nesting layouts " +
                "like LazyColumn and Column(Modifier.verticalScroll()). If you want to add a " +
                "header before the list of items please add a header as a separate item() before " +
                "the main items() inside the LazyColumn scope. There are could be other reasons " +
                "for this to happen: your ComposeView was added into a LinearLayout with some " +
                "weight, you applied Modifier.wrapContentSize(unbounded = true) or wrote a " +
                "custom layout. Please try to remove the source of infinite constraints in the " +
                "hierarchy above the scrolling container.

If you observe any bug in the toolkit - please file another issue, otherwise there's stackoverflow and kotlinlang slack where community can help with the code and error.

The change from comment#28 does not work for me, with a MapView. I tried replacing my painless requestDisallowInterceptTouchEvent() setup from comment#15 in compose 1.2.0-alpha08, following the example given in the commit from comment#28, with setNestedScrollingEnabled() on top of the MapView and a scrollable() Modifier on a parent Box. Am I missing something, or does this not work with MapView for some reason? My MapView is inside a horizontal accompanist pager; I tried both vertical and horizontal orientations for scrollable(), but either one just gets swallowed, and I cannot drag the map in the specified orientation, or drag the pager element.

Hi, thanks for your comment. The Modifier.scrollable in the example is just an illustration so one can see the scroll deltas being propagated up the nested scrolling chain across view and compose. If I understand you example correctly, you have a compose scrollable parent (HorizontalPager) + a View (MapView) child. In this case, just setNestedScrollingEnabled() should suffice.

Gotcha, thanks for the quick response. Alas, it did not fix my problem. What I want is to have my MapView be scrollable horizontally inside a horizontal accompanist pager. (There is more screen real estate besides the MapView that the user can drag the pager on.) With or without setNestedScrollingEnabled(), only the pager ever scrolls.

Here's the rough Compose tree:

HorizontalPager {
  Column {
    AndroidView({
      MapView().also { ViewCompat.setNestedScrollingEnabled(it, true) }
    })
    Text("Drag me to flip the page")
  }
}

Hey, so from the sample you added above, if you swipe on top of the text "Drag me to flip the page" the pager goes to the next page, but if you do the same on top of the map, you want the map to scroll instead of the pager? I can see how this would be the desired behavior, but ff this is the case we'll need to re-check. MapView is a "special" type of View and I don't think it dispatches NestedScrolling the same way other scrollable containers would (using the nested scrolling system).

Yes, that is the desired behavior. Short of Compose support, I am able to make it happen by wrapping the MapView inside this custom view; it's a pattern from androidx ViewPager2:

class TouchWrappingLayout(context: Context) : FrameLayout(context) {
    override fun onInterceptTouchEvent(e: MotionEvent): Boolean {
        parent.requestDisallowInterceptTouchEvent(true)
        return super.onInterceptTouchEvent(e)
    }
}

Hi, we are aware that nestedScroll has some issues with fling movements (see: https://b.corp.google.com/issues/179417109 and https://b.corp.google.com/issues/175010956). I'll follow-up when we have more updates on this. Thanks for reporting your issue!

I'm having trouble using Compose nested scrolling inside a BottomSheet. Scrolling upwards (so further down in a list) works fine, meaning it first expands the BottomSheet before scrolling in the Compose LazyColumn. However scrolling downwards (so further up in a list) immediately starts collapsing the BottomSheet instead of first scrolling to the top of the LazyColumn and then collapsing the BottomSheet. Is there a fix or workaround for this issue?

Here's an example:

XML:

<?xml version="1.0" encoding="utf-8"?>
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
	xmlns:app="http://schemas.android.com/apk/res-auto"
	android:layout_width="match_parent"
	android:layout_height="match_parent"
	android:background="@android:color/white">

	<LinearLayout
		android:id="@+id/bottomSheet"
		android:layout_width="match_parent"
		android:layout_height="wrap_content"
		android:background="#e9e9e9"
		android:orientation="vertical"
		android:padding="5dp"
		app:layout_behavior="@string/bottom_sheet_behavior">

		<androidx.compose.ui.platform.ComposeView
			android:id="@+id/composeContent"
			android:layout_width="match_parent"
			android:layout_height="match_parent" />
	</LinearLayout>

</androidx.coordinatorlayout.widget.CoordinatorLayout>

Activity:

class ComposeActivity : AppCompatActivity() {

	@OptIn(ExperimentalComposeUiApi::class)
	override fun onCreate(savedInstanceState: Bundle?) {
		super.onCreate(savedInstanceState)

		val binding = ActivityComposeBinding.inflate(layoutInflater)
		setContentView(binding.root)

		binding.composeContent.setContent {
			LazyColumn(
				Modifier
					.nestedScroll(rememberNestedScrollInteropConnection(binding.composeContent))
					.fillMaxSize()
			) {
				items(100) {
					Text("Item $it", Modifier.fillMaxWidth(), Color.Black)
				}
			}
		}
	}
}

Neither the official Compose rememberNestedScrollInteropConnection() nor the ViewInteropNestedScrollConnection from #9 fixes the problem I described in #37. I've attached a video showing the issue. When the bottom sheet is fully expanded and the nested composable is not scrolled to the top, I would expect to first scroll the nested composable and not start dragging the bottom sheet down until its collapsed state is reached.

Hi, I have tested #37 locally using rememberNestedScrollInteropConnection() and I see the correct behavior. Are you using the latest version of compose? I noticed your rememberNestedScrollInteropConnection still has binding.composeContent, whilst in the latest version we don't need to pass the compose view anymore.

This rememberNestedScrollInteropConnection() is not working for me. Can you please explain what is going wrong here?

My situation is that I'm building a bottom sheet with using BottomSheetDialogFragment. Here is my layout

<androidx.coordinatorlayout.widget.CoordinatorLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <androidx.compose.ui.platform.ComposeView
        android:id="@+id/composeView"
        android:layout_width="match_parent"
        android:layout_height="match_parent" />
</androidx.coordinatorlayout.widget.CoordinatorLayout>

Here is how I render my ComposeView, note that the top node of the ComposeView is not LazyColumn:

composeView.setContent {
  Column // Set nestedScroll(rememberNestedScrollInteropConnection()) here
    - Composable 1 (Top bar)
    - Columm(modifier = Modifier.weight(1f))
       - LazyColumn // Doesn't work with this LazyColumn here
    - Composable 2 (Bottom bar)
}

What I'm doing wrong here? Note that using the workaround from #9 works for me. I use #9 directly to the LazyColumn as it does not require binding with composeView.

#40: I am using Compose 1.2.0-alpha08, which at the time of writing is the latest version in the Google Maven. When checking the 1.2.0-alpha08 sources jar from here the rememberNestedScrollInteropConnection function in NestedScrollInteropConnection.kt still requires passing a ComposeView as parameter. I can see in the source code that this is no longer the case, but I guess that is not yet released?

I have attached a sample project which shows the behavior I reported in #37 using Compose 1.2.0-alpha08 and using either the official NestedScrollInteropConnection or the ViewInteropNestedScrollConnection from #9.

Hi #41, could you provide a full code sample so I can better understand and test it? From your sample alone I don't see anything apart the ComposeView inside your xml so I'm not sure why you're using the interop connection here. Thank you!

Hi #42, thanks for the sample. Yes, I'm looking into the schedule and it seems that it hasn't been released yet. You can copy and paste it to test it out, but I'm attaching a video I made with the latest version and this seems to be working. Once you're able to test it (either by copying and pasting or waiting for the next release) let me know if the issue is really solved. I'll keep an eye out for this, thanks for reporting!

Hi #44: I've updated to the new Compose 1.2.0-beta01 where the new parameter-less rememberNestedScrollInteropConnection() function is available. However, this update made it worse in my sample project, as the bottom sheet now no longer expands/shrinks at all when scrolling in the compose content. Only grabbing the bottom sheet itself changes the expanded state. I've attached a video of the new behavior.

Hi #46, this is the version of your sample I have used to generate the video above. I only made minimal changes to update the version and remove unnecessary code. I have just tried it again and it seems to be working.

If the sample you're using is different than this one, could you file a bug in another ticket so we can follow up from there?

Thank you.

Hi #47: You're right, it is working with the new 1.2.0-beta01. I still had a reference to the rememberViewInteropNestedScrollConnection(binding.composeContent) from #9 in the code, which interfered with the NestedScrollingChildHelper of the official rememberNestedScrollInteropConnection(). Thanks a lot for the support and the fix!

One of the issues here is that BottomSheetBehavior calls view.canScrollVertically() on the nested scrolling view. ComposeView doesn't implement that, so it's a bit broken atm. I'm surprised this wasn't picked up in testing?

We previously had a workaround of manually creating a 'proxy' nested scrolling view, attaching it via AndroidView and then instrumenting its canScrollVertically function based on the LazyListState. That no longer works in Compose 1.2.0 as rememberNestedScrollInteropConnection() uses the LocalView internally rather than allowing us to pass that view through.

Hi #49, thank you for reporting this. I looked into your sample and I think some clarifications are needed, we're working on adding more documentation around the nested scroll interop in order to avoid confusions in the future, but for now here's the explanation:

• rememberNestedScrollInteropConnection will install a NestedScrollConnection in the element you attached it to, in this case the Box element. The NestedScrollConnection is responsible for transmitting the deltas from the Compose level to the View level. Note that it enables the element to participate in nested scrolling, but it doesn't scroll elements automatically.
• Box is not scrollable automatically, so when you touch the non-scrollable area it, Compose won't propagate deltas in the nested scroll system and the deltas won't reach the NestedScrollConnection provided by rememberNestedScrollInteropConnection, therefore those deltas won't reach the view world.
• When you touch the scrollable portion of compose, the LazyList, the deltas are propagated in the nested scroll system and that's why it works when you scroll it.
• To have the scrolling deltas reach the view world you'd need to either include your text in the Lazy list as a one-off element (using the item{} DSL or to make your outter box scrollable using the .scrollable modifier.

Hopefully the explanation makes sense, let us know what you think. Thank you!

Hi #51, the issues with fling is on our roadmap for upcoming releases, stay tuned to these two tickets (https://issuetracker.google.com/issues/216582726 https://issuetracker.google.com/issues/175010956) and and we'll update them accordingly. Thank you!

It seems that this was fixed in 1.2.0-alpha07 and 08

https://developer.android.com/jetpack/androidx/releases/compose-ui#1.2.0-alpha08

Somehow ViewCompat.setNestedScrollingEnabled doesn't work for me. The code below is oversimplified, but correctly represents the view heierachy, which I have.

HorizontalPager {
    AndroidView({
      FrameLayout()
         .also { ViewCompat.setNestedScrollingEnabled(it, true) }
         .also { frame ->
            val recycler = RecyclerView()
            ViewCompat.setNestedScrollingEnabled(recycler, true) 
            frame.addView(recycler)
         }
      }
    })
}

The RecyclerView simply does not scroll.