[Test] AndroidComposeTestRule for Activity with custom input needs activityProvider [174472899]

Fixed

Bug

Status Update

No update yet.

Description

jo...@google.com

created issue #1

Nov 30, 2020 03:46PM

Jetpack Compose release version: Snapshot 6995125 Android Studio Build: n/a

See update to Alpha08 in Crane: https://github.com/android/compose-samples/pull/298/files#diff-b10b1fb51606b96175c832427089cc3f024a536153eab5cdbb95e4a7bb273b7cR60-R74

The AndroidComposeTestRule class has been changed in Alpha08, and it now needs an activityProvider parameter. That requires quite some boilerplate, as ActivityScenarioRule.getActivity() is private (AndroidComposeTestRule.kt line 311), and so the consumer has to copy that implementation.

Comments

pa...@google.com <pa...@google.com> #2Nov 30, 2020 04:03PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

jo...@google.com <jo...@google.com> #3Dec 2, 2020 03:28PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

pa...@google.com <pa...@google.com> #4Dec 8, 2020 05:18PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

jo...@google.com <jo...@google.com> #5Dec 9, 2020 10:15AM

deleted

je...@google.com <je...@google.com> #6Jan 14, 2021 05:28PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

je...@google.com <je...@google.com> #7Jan 19, 2021 12:54PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

pa...@google.com <pa...@google.com> Jan 20, 2021 05:46PM

Reassigned to je...@google.com.

ap...@google.com <ap...@google.com> #8Jan 20, 2021 06:31PM

Marked as fixed.

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.