[<= API 28] Wrong canAuthenicate status on devices without Fingerprint feature. [174505824]

Fixed

Bug

Status Update

No update yet.

Description

ig...@gmail.com

created issue #1

Nov 30, 2020 11:14PM

If this is a bug in the library, we would appreciate if you could attach: This bug is reproducible when the device(without fingerprint feature) hasn't PIN-protected enable and you call canAuthenticate() method. It returns the status BIOMETRIC_ERROR_NONE_ENROLLED, but should return BIOMETRIC_ERROR_NO_HARDWARE.

In case if PIN protect is enabled, canAuthenticate returns BIOMETRIC_ERROR_NO_HARDWARE

It simply to fix. You should check first if the device has a Fingerprint feature before you check mInjector.isDeviceSecuredWithCredential() on line 376.

BUILD INFO

Device type: Galaxy Tab A(8.0" 2019) android 9
OS version: API 28
Biometric library version: 1.1.0-rc01

STEPS TO REPRODUCE

Make sure PIN/Password/Pattern disabled on device
Call canAuthenticate method in BiometricManager instance

EXPECTED RESULTS

BIOMETRIC_ERROR_NO_HARDWARE

OBSERVED RESULTS

BIOMETRIC_ERROR_NONE_ENROLLED

everytime

Comments

ca...@gmail.com <ca...@gmail.com> #2Dec 1, 2020 07:51PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

cu...@google.com <cu...@google.com> Jan 15, 2021 09:24PM

Reassigned to cu...@google.com.

ap...@google.com <ap...@google.com> #3Jan 19, 2021 09:28PM

Marked as fixed.

Great! Thanks a lot, I'll look for the live updates soon!

an...@gmail.com <an...@gmail.com> #4Aug 11, 2021 02:52PM

Comment has been deleted.

Message last modified on Aug 11, 2021 03:05PM

Issue 174505824

Description

Issue summary

Comments

ca...@gmail.com <ca...@gmail.com> #2Dec 1, 2020 07:51PM

cu...@google.com <cu...@google.com> Jan 15, 2021 09:24PM

ap...@google.com <ap...@google.com> #3Jan 19, 2021 09:28PM

an...@gmail.com <an...@gmail.com> #4Aug 11, 2021 02:52PM

Add comment

Issue metadata