@RequiresOptIn APIs appear in current.txt [174531520]

Fixed

Bug

Status Update

No update yet.

Description

to...@google.com

created issue #1

Dec 1, 2020 04:34AM

When removing @Experimental and replacing it with @RequiresOptIn only, the experimental APIs are added into current.txt after running updateApi (both current.txt and public_plus_experimental_current.txt have the APIs). See aosp/1507277 ExperimentalCamera2Interop as example.

Comments

al...@google.com <al...@google.com> Dec 1, 2020 03:31PM

Status: Assigned (reopened)

al...@google.com <al...@google.com> #2Dec 1, 2020 07:32PM

Reassigned to al...@google.com.

This turned out to be slightly more serious than I had hoped -- we weren't tracking experimental APIs correctly, so they were able to leak in to non-experimental public APIs.

ap...@google.com <ap...@google.com> #3Dec 3, 2020 07:46PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5d02a0386fbec7ae1eed77de106c56f2cf6e342c
Author: Alan Viverette <alanv@google.com>
Date: Tue Dec 01 14:31:21 2020

Fix experimental annotation in Pager

Bug: 174531520
Test: ./gradlew updateApi
Relnote: "Pager now has a single experimental constructor alongside its
regular constructors, rather than leaking experimental APIs into
non-experimental public API via the opt-in annotation."
Change-Id: I9dc614204842258a72be000c6e37846fb85470c1

M paging/common/api/current.txt
M paging/common/api/public_plus_experimental_current.txt
M paging/common/api/restricted_current.txt
M paging/common/src/main/kotlin/androidx/paging/Pager.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomViewModel.kt

https://android-review.googlesource.com/1513218

to...@google.com <to...@google.com> #4Jan 19, 2021 06:36AM

May I know when the fix will be dropped? Cause I'm still getting the issue.

ap...@google.com <ap...@google.com> #5Mar 3, 2021 02:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit 43ee99022437df7e76f1e86a53c3d22ac4bd3805
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 01 15:38:44 2021

Update Metalava hide annotations to include RequiresOptIn

Fixes API files for affected projects. Suppresses some warnings in Compose
Material library and changes visiblity as a workaround for @PublishedApi
in Compose UI library.

Bug: 174531520
Test: ./gradlew updateApi
Relnote: Enforce restrictions on public usage of experimental APIs
Merged-In: I6aa29518ed4d6a3821d921d2ae1a300e31183dcc
Change-Id: I6aa29518ed4d6a3821d921d2ae1a300e31183dcc

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/app/app/api/1.0.0-beta02.txt
M car/app/app/api/current.txt
M car/app/app/api/restricted_1.0.0-beta02.txt
M car/app/app/api/restricted_current.txt
M compose/animation/animation-core/api/1.0.0-beta02.txt
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/restricted_1.0.0-beta02.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation/api/1.0.0-beta02.txt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/restricted_1.0.0-beta02.txt
M compose/animation/animation/api/restricted_current.txt
M compose/foundation/foundation-layout/api/1.0.0-beta02.txt
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/restricted_1.0.0-beta02.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation/api/1.0.0-beta02.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta02.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/material/material/api/1.0.0-beta02.txt
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_1.0.0-beta02.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/runtime/runtime/api/1.0.0-beta02.txt
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/restricted_1.0.0-beta02.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/ui/ui-test/api/1.0.0-beta02.txt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta02.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_1.0.0-beta02.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/jvmMain/kotlin/androidx/compose/ui/test/TestMonotonicFrameClock.jvm.kt
M compose/ui/ui-text/api/1.0.0-beta02.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta02.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-tooling-data/api/1.0.0-beta02.txt
M compose/ui/ui-tooling-data/api/current.txt
M compose/ui/ui-tooling-data/api/restricted_1.0.0-beta02.txt
M compose/ui/ui-tooling-data/api/restricted_current.txt
M compose/ui/ui/api/1.0.0-beta02.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_1.0.0-beta02.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/WindowRecomposer.android.kt
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava3/api/current.txt
M datastore/datastore-rxjava3/api/restricted_current.txt
M paging/common/api/3.0.0-beta01.txt
M paging/common/api/3.0.0-beta02.txt
M paging/common/api/current.txt
M paging/common/api/restricted_3.0.0-beta01.txt
M paging/common/api/restricted_3.0.0-beta02.txt
M paging/common/api/restricted_current.txt
M paging/guava/api/3.0.0-beta01.txt
M paging/guava/api/3.0.0-beta02.txt
M paging/guava/api/current.txt
M paging/guava/api/restricted_3.0.0-beta01.txt
M paging/guava/api/restricted_3.0.0-beta02.txt
M paging/guava/api/restricted_current.txt
M paging/rxjava2/api/3.0.0-beta01.txt
M paging/rxjava2/api/3.0.0-beta02.txt
M paging/rxjava2/api/current.txt
M paging/rxjava2/api/restricted_3.0.0-beta01.txt
M paging/rxjava2/api/restricted_3.0.0-beta02.txt
M paging/rxjava2/api/restricted_current.txt
M paging/rxjava3/api/3.0.0-beta01.txt
M paging/rxjava3/api/3.0.0-beta02.txt
M paging/rxjava3/api/current.txt
M paging/rxjava3/api/public_plus_experimental_3.0.0-beta01.txt
M paging/rxjava3/api/public_plus_experimental_3.0.0-beta02.txt
M paging/rxjava3/api/public_plus_experimental_current.txt
M paging/rxjava3/api/restricted_3.0.0-beta01.txt
M paging/rxjava3/api/restricted_3.0.0-beta02.txt
M paging/rxjava3/api/restricted_current.txt
M paging/rxjava3/src/main/java/androidx/paging/rxjava3/PagingRx.kt
M room/runtime/api/2.3.0-beta02.txt
M room/runtime/api/2.3.0-beta03.txt
M room/runtime/api/current.txt
M room/runtime/api/restricted_2.3.0-beta02.txt
M room/runtime/api/restricted_2.3.0-beta03.txt
A room/runtime/api/restricted_current.ignore
M room/runtime/api/restricted_current.txt

https://android-review.googlesource.com/1595352

al...@google.com <al...@google.com> Mar 3, 2021 02:29AM

Marked as fixed.

Issue 174531520