generateReleaseLintModel fails when lintOptions.checkDependencies = true in AGP 7.0.0-alpha01. [174605126]

Fixed

Bug

Status Update

No update yet.

Description

yc...@gmail.com

created issue #1

Dec 2, 2020 11:48AM

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Version of Gradle Plugin: 7.0.0-alpha01 Version of Gradle: 6.8-rc-1 Version of Java: 14 OS: macOS, ubuntu

I just updated a project to AGP 7.0.0-alpha01 and started getting unable to find project exploded aar for ProjectKey(buildId=/path/project-name, projectPath=:module, variantName=debug) with failure on task generateDebugLintModel when running lint.

This only seems to happen when lintOptions.checkDependencies is set to true on the :app module

Steps to Reproduce:

Check out this project
run ./gradlew app:lintProdRelease

Here's a build log on CI: https://github.com/ReactiveCircus/streamlined/runs/1485550505?check_suite_focus=true

Comments

ga...@google.com <ga...@google.com> Dec 2, 2020 05:12PM

Assigned to cm...@google.com.

cm...@google.com <cm...@google.com> #2Dec 3, 2020 12:02PM

Accepted by cm...@google.com.

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Android build
Which Android build are you using? (e.g. PPP5.180610.010)

We tested this bug on Pixel devices and observed, it says:
"a% with valuetext slider".
Please confirm if you have also observed the same.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Screen record of the issue
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.

Note: Please avoid uploading directly to the issue using attachments. Please upload to google drive and share the folder to android-bugreport@google.com, then share the link here.

ig...@ab-inbev.com <ig...@ab-inbev.com> #3Dec 3, 2020 01:23PM

Android Build: 00WW_4_15C_SP02
Yes - it says (for example) "50% (pause) with value text (pause) slider"

cm...@google.com <cm...@google.com> #4Dec 3, 2020 05:32PM

Thanks for the above inputs. Could you please clarify the expected output.

cm...@google.com <cm...@google.com> #5Dec 3, 2020 05:33PM

I would expect it to read the value of aria-valuetext not the % as the author has specifically determined that this is the value that should be read. So in the example above it would read "5000 (pause) with value text (pause) slider"

Often in these cases the value is not even numeric. For example 2 of the sliders at https://w3c.github.io/aria-practices/examples/slider/slider-2.html (although these are ARIA sliders so I wouldn't expect them to work with Talkback until AOM is implemented)

cm...@google.com <cm...@google.com> #6Dec 4, 2020 10:19AM

Marked as fixed.

We’ve shared this with our product and engineering teams and will continue to provide updates as more information becomes available.

ig...@gmail.com <ig...@gmail.com> #7Dec 15, 2020 10:44AM

W3C ARIA APG working group is creating the slider examples with role slider. According to multiple talkback testing reports, role slider does not work in reading the slider value or the changed value.

Review/talkback testing results comments:

https://github.com/w3c/aria-practices/pull/1746#issuecomment-774498523
https://github.com/w3c/aria-practices/pull/1746#pullrequestreview-600408013
https://github.com/w3c/aria-practices/pull/1755#issuecomment-778638021
https://github.com/w3c/aria-practices/pull/1755#issuecomment-782607921
https://github.com/w3c/aria-practices/pull/1746#issuecomment-784788395
https://github.com/w3c/aria-practices/pull/1746#issuecomment-787642775
https://github.com/w3c/aria-practices/pull/1746#issuecomment-787662740
I had video recording of talk back for the example in the issue. But I cannot find it. sorry.

Related ARIA APG slider role PR

cm...@google.com <cm...@google.com> #8Dec 15, 2020 01:29PM

Marked as fixed.

Marking as Won't Fix since this seems to be an issue with the site used for testing and not Chrome.

cm...@google.com <cm...@google.com> #9Dec 15, 2020 01:58PM

deleted

Message last modified on Dec 15, 2020 01:59PM

ig...@gmail.com <ig...@gmail.com> #10Dec 15, 2020 02:08PM

I deleted my comment because of a mistake in expected/actual. Update coming shortly.

cm...@google.com <cm...@google.com> #11Dec 16, 2020 01:42PM

The initial report says the value text is ignored, but comment 2 and comment 3 indicate the following update should be made:

Actual: “50% (pause) with value text (pause) slider”
Expected: “50000 (pause) with valuetext (pause) slider”
(The "50000" is the aria-valuetext" and "with valuetext" is the label of the control).

I agree that we aren't matching ARIA usability expectations. Using aria-valuetext needs to override any reporting of a number or percentage.
For example, a slider could be used for "low", "medium", "high" or days of the week. The percentage would not make sense.
Please reference

https://www.w3.org/TR/wai-aria-1.2/#aria-valuetext
"If aria-valuetext is specified, assistive technologies SHOULD render that value instead of the value of aria-valuenow." (the current slider value is equivalent to aria-valuenow).

Note: the reporter in this case is the chair of the ARIA WG, so he knows what he's talking about. Please don't close without further discussion from an engineer.

ig...@gmail.com <ig...@gmail.com> #12Dec 26, 2020 04:42PM

Tested this with TalkBack 9.1 and Chrome 92.0.4515.159 (both latest versions as far as I could tell) and can confirm that the error is still present - input type range is still announcing values in percents. It's even happening for "barebones" input type range;

<label for="d">Select your donation from 100$ to 1000$</label> <input id="d" type="range" step="100" min="100" max="1000" value="100">

This bug is preventing usage of input type range for many other scenarios that need other ranges than 0-100%

Other screen-readers (on PC and iPhone) pronounce the values provided by developers.

Test page with 2 input type range examples : https://jsfiddle.net/mdu8903f/1/ (full page: https://jsfiddle.net/mdu8903f/1/show)

cm...@google.com <cm...@google.com> #13Jan 5, 2021 03:04PM

Could you please re-test the bug on Chrome version 96.0.4657.0 and above and share your feedback.