Status Update
Comments
da...@google.com <da...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@google.com <da...@google.com> #3
xu...@gmail.com <xu...@gmail.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ro...@rockspin.co.uk <ro...@rockspin.co.uk> #5
workaround for now
def room_version = "2.3.0-alpha03"
implementation("androidx.room:room-runtime:$room_version") {
exclude(group:'org.xerial')
}
kapt("androidx.room:room-compiler:$room_version"){
exclude(group:'org.xerial')
}
implementation("androidx.room:room-ktx:$room_version"){
exclude(group:'org.xerial')
}
implementation 'org.xerial:sqlite-jdbc:3.34.0'
ap...@google.com <ap...@google.com> #6
Branch: androidx-main
commit abddddd5b5040e47ae1c28153343fef168036341
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Dec 15 09:16:21 2020
Update xerial sqlite-jdbc library.
Updating to 3.34.0 that support Apple's M1 chip arch 'aarch64'.
Bug: 174695268
Test: n/a - I don't have an M1 Mac...
Relnote: Update Room dependencies to support Apple's M1 CPUs.
Change-Id: Ieb6dd72b5443d7ec555a0720bff84bc413fc144c
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
da...@google.com <da...@google.com>
da...@google.com <da...@google.com>
le...@gmail.com <le...@gmail.com> #7
da...@google.com <da...@google.com> #8
Not yet sorry, we ran into an issue with the JDBC library (
mx...@gmail.com <mx...@gmail.com> #9
For those who are facing this problem, you can simply add this line before the room-compiler
as a workaround now:
+kapt("org.xerial:sqlite-jdbc:3.34.0")
kapt("androidx.room:room-compiler:2.3.0-beta01")
ce...@gmail.com <ce...@gmail.com> #10
If the mentioned workarounds are not working, I recommend using this workaround instead, adding it to the root build.gradle. This will force using the given dependency in the whole project:
allprojects {
configurations.all {
resolutionStrategy {
force 'org.xerial:sqlite-jdbc:3.34.0'
}
}
}
za...@gmail.com <za...@gmail.com> #11
You should use configureEach instead of all, FYI!
ro...@gmail.com <ro...@gmail.com> #12
da...@google.com <da...@google.com>
za...@gmail.com <za...@gmail.com> #13
Just a note for others - fixed *in room 2.4.0-alpha03
zh...@gmail.com <zh...@gmail.com> #14
we need a patch version for 2.3.x
za...@gmail.com <za...@gmail.com> #15
You have a workaround for that
zh...@gmail.com <zh...@gmail.com> #16
why not release room 2.4.0, it's alpha until now!!!!!
za...@gmail.com <za...@gmail.com> #17
On Thu, Sep 2, 2021 at 2:27 AM <buganizer-system@google.com> wrote:
[Deleted User] <[Deleted User]> #18
10-26 14:16:44.108 E/AndroidRuntime(26052): Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/sqlite/db/SupportSQLiteCompat$Api19Impl;
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.room.RoomDatabase$JournalMode.isLowRamDevice(RoomDatabase.java:755)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.room.RoomDatabase$JournalMode.resolve(RoomDatabase.java:746)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.room.RoomDatabase$Builder.build(RoomDatabase.java:1446)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.impl.WorkDatabase.create(WorkDatabase.java:155)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:244)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.impl.WorkManagerImpl.<init>(WorkManagerImpl.java:219)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.impl.WorkManagerImpl.initialize(WorkManagerImpl.java:198)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.WorkManager.initialize(WorkManager.java:210)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.WorkManagerInitializer.create(WorkManagerInitializer.java:39)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.work.WorkManagerInitializer.create(WorkManagerInitializer.java:30)
10-26 14:16:44.108 E/AndroidRuntime(26052): at androidx.startup.AppInitializer.doInitialize(AppInitializer.java:155)
yb...@google.com <yb...@google.com> #19
#18, you might be hitting multi-dex issues. Do you have multi-dex enabled?
[Deleted User] <[Deleted User]> #20
I created a dedicated issue to track this:
0....@gmail.com <0....@gmail.com> #22
Caused by: java.lang.IllegalArgumentException: @androidx.room.Database does not define an element autoMigrations()
at com.google.auto.common.AnnotationMirrors.getAnnotationElementAndValue(AnnotationMirrors.java:134)
Description
Component used: Room
Version used: 2.2.5
Devices/Android versions reproduced on: Mac mini M1 chip
JDK8-arm64 is downloaded from Zulu Builds of OpenJDK
Gradle stacktrace: