Navigation arguments of type boolean array cannot be null [174787525]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Dec 4, 2020 12:20PM

Using androidx.navigation:navigation-safe-args-gradle-plugin:2.3.2

when if compile my projet with a boolean array argument and set its default value to @null

<argument
    android:name="multiChoiceCheckedItems"
    android:defaultValue="@null"
    app:argType="boolean[]"
    app:nullable="true" />

I get an error:

androidx.navigation.safeargs plugin failed
Execution failed for task ':app:generateSafeArgsDebug'.
> androidx.navigation.safeargs plugin failed.
   Following errors found: 
  W:\Projects\HelloBirdieAndroid\app\src\main\res\navigation\navigation_main.xml:136:9 (navigation_main.xml:136): 
  error: 'boolean[]' is a simple type and cannot be nullable. Remove app:nullable="true" from the argument.

Although documentation do not mention any problem with boolean array and explicitly mention that any array argument can have only one default value "@null". https://developer.android.com/guide/navigation/navigation-pass-data#supported_argument_types

Comments

il...@google.com <il...@google.com> Oct 4, 2021 10:49PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Nov 16, 2021 05:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit ff83342e064a03ea410b31f825786c28d009354f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Nov 16 08:17:07 2021

Allow nullable boolean array in safe args

While you should not be able to give a boolean a default value of null
you should be able to make an array default to null. We need to enable
safe args to generate boolean array with nullable values.

RelNote: "Fixed a bug in safe args that would not allow boolean arrays
to have a `null` value."
Test: modified NavParserTest
Bug: 174787525

Change-Id: I8c396c8f174d5924bb5ee147261de158256fba94

M navigation/navigation-safe-args-generator/src/test/test-data/naive_test.xml
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt

https://android-review.googlesource.com/1893757

jb...@google.com <jb...@google.com> #3Nov 16, 2021 05:57PM

Marked as fixed.

This has been fixed internally and will be available in the next Navigation release. You can try it out now by following the snapshot instructions and using buildID #7920634.

Issue 174787525

Description

Issue summary

Comments

il...@google.com <il...@google.com> Oct 4, 2021 10:49PM

ap...@google.com <ap...@google.com> #2Nov 16, 2021 05:31PM

jb...@google.com <jb...@google.com> #3Nov 16, 2021 05:57PM

Add comment

Issue metadata