Fixed
Status Update
Comments
du...@google.com <du...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7b53a60a67bf1d2c354dfb0bfe1f1ebfb66d02e0
Author: Dustin Lam <dustinlam@google.com>
Date: Fri Dec 04 12:36:36 2020
Reset footer / header state after dropping in separators
Resolves a crash with IllegalStateException due to the requires() check
ensuring our internal state is up-to-date.
Relnote: "Fixed a crash due to IllegalStateException when
using separators with PagingConfig.maxSize set."
Fixes: 174787528
Test: ./gradlew paging:paging-common:test
Change-Id: I0ed33e86d3a09e1fb5f157c841331238d7ff83b4
M paging/common/src/main/kotlin/androidx/paging/Separators.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsTest.kt
https://android-review.googlesource.com/1518403
Branch: androidx-master-dev
commit 7b53a60a67bf1d2c354dfb0bfe1f1ebfb66d02e0
Author: Dustin Lam <dustinlam@google.com>
Date: Fri Dec 04 12:36:36 2020
Reset footer / header state after dropping in separators
Resolves a crash with IllegalStateException due to the requires() check
ensuring our internal state is up-to-date.
Relnote: "Fixed a crash due to IllegalStateException when
using separators with PagingConfig.maxSize set."
Fixes: 174787528
Test: ./gradlew paging:paging-common:test
Change-Id: I0ed33e86d3a09e1fb5f157c841331238d7ff83b4
M paging/common/src/main/kotlin/androidx/paging/Separators.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsTest.kt
Description
Component used: Paging Version used: 3.0.0-alpha10 Devices/Android versions reproduced on: Pixel 1, Android 9.x
I'm seeing the following exception when using the latest alpha when I set a
maxSize
. Without it, there's no crash - our objects are fairly heavy memory wise so I do want to set it.pageSize
/prefetchDistance
are both 20 FWIW.To reproduce, I do the following:
maxSize
to 200I have tried the same reproduction steps on alpha09 and can confirm that I see the crash there too.
Seems potentially related tohttps://android-review.googlesource.com/c/platform/frameworks/support/+/1482701 which has a similar stacktrace when it crashes?