Fixed
Status Update
Comments
cl...@google.com <cl...@google.com>
ma...@google.com <ma...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 33efbf2404fde2e2d28aaa07caeb82df33cb3203
Author: Jose Alba Aguado <jaguado@google.com>
Date: Tue Feb 02 17:09:22 2021
Checkbox: Removed transparent line between box/border when selected
Test: CheckboxScreenshotTest
Bug: 175198975
Bug: 168878958
Change-Id: I829bd04f2c5edf12488ca8609a9a81c4c8d17c51
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
https://android-review.googlesource.com/1572740
Branch: androidx-main
commit 33efbf2404fde2e2d28aaa07caeb82df33cb3203
Author: Jose Alba Aguado <jaguado@google.com>
Date: Tue Feb 02 17:09:22 2021
Checkbox: Removed transparent line between box/border when selected
Test: CheckboxScreenshotTest
Bug: 175198975
Bug: 168878958
Change-Id: I829bd04f2c5edf12488ca8609a9a81c4c8d17c51
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
cl...@google.com <cl...@google.com>
ca...@gmail.com <ca...@gmail.com> #5
For me it's still failing with the last release version, now only the corners of the faint line are visible, but still there. I've attached a screenshot.
lp...@google.com <lp...@google.com> #6
Jose, would you mind taking another look? It looks like we still might have a small rounding issue somewhere for the corners.
ca...@gmail.com <ca...@gmail.com> #7
Also, I've found that when you use `Modifier.scale()` the faint line appears another time. I've added more info in this ticket https://issuetracker.google.com/issues/197280891
lp...@google.com <lp...@google.com>
sg...@google.com <sg...@google.com>
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit baee4b7a78016b96963a586aa6981de02d700750
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Nov 22 18:04:59 2021
Fixes Checkbox issues
- Draw a single round rect in case the checkbox internal color is the
same as its border color.
- Fix the checkbox corner radius, which appeared to be rendered as more
than the spec's 2dp value.
Bug: 175198975, 202309440
Test: CheckboxTest & CheckboxScreenshotTest
Relnote: "Fix the corner radius that is applied for Checkboxes"
Change-Id: I38b03cda11bf28245a3af3d726ddd0bb9cbe8fa6
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt
https://android-review.googlesource.com/1900059
Branch: androidx-main
commit baee4b7a78016b96963a586aa6981de02d700750
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Nov 22 18:04:59 2021
Fixes Checkbox issues
- Draw a single round rect in case the checkbox internal color is the
same as its border color.
- Fix the checkbox corner radius, which appeared to be rendered as more
than the spec's 2dp value.
Bug: 175198975, 202309440
Test: CheckboxTest & CheckboxScreenshotTest
Relnote: "Fix the corner radius that is applied for Checkboxes"
Change-Id: I38b03cda11bf28245a3af3d726ddd0bb9cbe8fa6
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt
Description
I noticed a really faint line in Material's Checkbox that looks broken. The line appears in between the 'border' and the 'box' parts of the Checkbox. See the attached image