prefab processing does not run if the referenced prefab aar library is `project('...')` [175291074]

Duplicate

of 120166563

Bug

Status Update

No update yet.

Description

at...@gmail.com

created issue #1

Dec 10, 2020 08:51PM

Build: AI-202.7319.50.2031.7006259, 202012020750,

AI-202.7319.50.2031.7006259, JRE 11.0.8+0-b944-P17168821x64 JetBrains s.r.o, OS Linux(amd64) v5.4.0-56-generic, screens 2880x1620

AS: Arctic Fox | 2020.3.1 Canary 2; Kotlin plugin: 1.4.21-release-Studio4.2-1; Android Gradle Plugin: 7.0.0-alpha02; Gradle: 6.7.1; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: 3.16.3Source: user_sentiment_feedback

I am experimentally migrating my project to prefab. It has a prefab AAR library module and sample app modules in the project. The samples reference the library as dependencies { implementation project(':...') }.

I expected that prefab contents are resolved for project(...) too, but current AGP fails to handle it, and thus cmake build fails like this:

> Task :aapbarebonepluginsample:generateJsonModelDebug FAILED
prefabUsage: prefab [OPTIONS] [PACKAGE_PATH]...
prefabError: Invalid value for "PACKAGE_PATH": Directory "/media/atsushi/extssd0/sources/android-audio-plugin-framework/java/androidaudioplugin/build/intermediates/prefab_package/debug/prefab" is not readable.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':aapbarebonepluginsample:generateJsonModelDebug'.
> error when building with cmake using /media/atsushi/extssd0/sources/android-audio-plugin-framework/java/samples/aapbarebonepluginsample/CMakeLists.txt: Build command failed.
  Error while executing java process with main class com.google.prefab.cli.AppKt with arguments {--build-system cmake --platform android --abi armeabi-v7a --os-version 29 --stl c++_shared --ndk-version 21 --output /media/atsushi/extssd0/sources/android-audio-plugin-framework/java/samples/aapbarebonepluginsample/.cxx/cmake/debug/prefab/armeabi-v7a/prefab /media/atsushi/extssd0/sources/android-audio-plugin-framework/java/androidaudioplugin/build/intermediates/prefab_package/debug/prefab}
  
  Usage: prefab [OPTIONS] [PACKAGE_PATH]...
  
  Error: Invalid value for "PACKAGE_PATH": Directory "/media/atsushi/extssd0/sources/android-audio-plugin-framework/java/androidaudioplugin/build/intermediates/prefab_package/debug/prefab" is not readable.

If I replace those dependencies with packages that were installed locally (by 'maven-publish` and mavenLocal()) then it builds. But obviously that's not how we can form the project, the dependency resolution matters.

Since the AAR cannot contain jniLibs due to https://issuetracker.google.com/issues/168777344 I am stuck with the current situation.

Comments

at...@gmail.com <at...@gmail.com> #2Dec 10, 2020 09:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a071470cde57cf7eb6e39a67d331d716a0f8b842
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 15 14:01:37 2020

Add SpecialEffectsController infrastructure

"Special Effects" is the blanket term for
Animation, Animator, framework Transition, and
AndroidX Transition that Fragments currently support.

Add the infrastructure around a SpecialEffectsController
which would operate on the container (i.e., ViewGroup)
level and coordinate all of the special effects.

This will eventually allow us to track the
postponed state at the container level.

Currently all APIs are purposefully package private
as they should not be used by external developers
at this time.

BUG: 147749580
Test: new test suites pass
Change-Id: I1e209bb4f55c21aa01afb49035d41f5b8d7d3eca

A fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
A fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
A fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsControllerFactory.java
M fragment/fragment/src/main/res/values/ids.xml
M jetifier/jetifier/migration.config

https://android-review.googlesource.com/1209367

uc...@google.com <uc...@google.com> Dec 10, 2020 11:55PM

Assigned to an...@google.com.

em...@google.com <em...@google.com> Dec 16, 2020 11:12PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> Dec 17, 2020 12:19AM

Status: Duplicate of

120166563

jo...@google.com <jo...@google.com> #3Aug 12, 2021 04:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d990bffa6728272e139e1b5d58e764e9197b1adc
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 16 14:05:14 2020

Find the appropriate SpecialEffectsControllerFactory

Instead of requiring each call to
getOrCreateController() require passing in the
factory, use findFragmentManager() to find the
containing FragmentManager and get the factory from
it.

Test: new test passes
BUG: 147749580
Change-Id: I44f747ba84feb2911a8d0811e40d1b46644429a5

M fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1210675

bo...@gmail.com <bo...@gmail.com> #4May 4, 2022 10:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 62e13263d9ee368a255cfb7db73eba061ca85f9c
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 17 13:09:12 2020

Allow cancellation of special effects operations

Pipe through a CancellationSignal to Operation
so that a SpecialEffectsController can handle
cancellation.

Test: new test passes
BUG: 147749580
Change-Id: Iff9525a3d3e079a3b0b6818e43e6efdb16207a7a

M fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1212445

bo...@gmail.com <bo...@gmail.com> #5May 4, 2022 10:55PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9ea0884726565254629ff5c99ec919f56e0af1d9
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 17 11:09:14 2020

Allow enqueuing special effects operations

Build the initial infrastructure for enqueuing
ADD and REMOVE operations to a SpecialEffectsController.

This currently doesn't change any runtime behavior
since DefaultSpecialEffectsController doesn't actually
do anything and FragmentStateManager isn't used to
move Fragments beyond CREATED with moveToExpectedState()
in production code.

Cancellation will be handled in a follow up CL.

Test: new SpecialEffectsControllerTest tests pass
BUG: 147749580
Change-Id: I6a3009de80419fd878f2f838bf8e234c20b933ae

M fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1212444

ha...@gmail.com <ha...@gmail.com> #6Jan 18, 2023 04:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d67221893efc073415220d4d3635f159e728b905
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 21 16:49:50 2020

Add isAwaitingCompletion() API

Build the infrastructure for allowing the
FragmentStateManager to check whether a
SpecialEffectsController is still awaiting
completion of queued up / executing
operations.

Test: updated tests to call new API
BUG: 147749580
Change-Id: I6ebd563c505dc2e7b65ced4932316986c478a8cf

M fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1214213