Scaffold's BottomBar [175392262]

Fixed

Bug

Status Update

No update yet.

Description

qu...@gmail.com

created issue #1

Dec 12, 2020 06:41AM

Jetpack Compose release version: 1.0.0-alpha08 Android Studio Build: Android Studio Arctic Fox | 2020.3.1 Canary 2

BottomBar no longer updates Scaffold's contentPadding whenever bottomBar changes "visibility".

Here is the sample code to reproduce:

@ExperimentalAnimationApi
@Composable
fun FillingIssues() {
    val navController = rememberNavController()

    Scaffold(
        bottomBar = {
            val currentBackStack by navController.currentBackStackEntryAsState()
            val route = currentBackStack?.arguments?.getString(KEY_ROUTE)
            AnimatedVisibility(
                visible = route == SECOND_SCREEN,
                exit = slideOutVertically(
                    targetOffsetY = { it },
                ),
                enter = slideInVertically(
                    initialOffsetY = { it },
                ),
            ) {
                Surface(
                    modifier = Modifier.fillMaxWidth()
                        .wrapContentHeight()
                        .shadow(8.dp, clip = false),
                    elevation = 8.dp,
                    color = MaterialTheme.colors.surface,
                ) {
                    Text(
                        modifier = Modifier.fillMaxWidth(),
                        text = "Bottom Bar",
                        textAlign = TextAlign.Center,
                    )
                }
            }
        }
    ) { padding ->
        val modifier = Modifier.padding(padding)
        NavHost(navController, startDestination = FIRST_SCREEN) {
            composable(FIRST_SCREEN) {
                MyScreen(modifier, Color.Blue) {
                    navController.navigate(SECOND_SCREEN)
                }
            }
            composable(SECOND_SCREEN) {
                MyScreen(modifier, Color.Red) {
                    navController.navigate(FIRST_SCREEN)
                }
            }
        }
    }

}

@Composable
fun MyScreen(
    modifier: Modifier,
    color: Color,
    onClick: () -> Unit,
) {
    Column(
        modifier.fillMaxSize(),
        Arrangement.Center,
        Alignment.CenterHorizontally
    ) {
        Box(modifier = Modifier.weight(1f).background(color))
        Button(onClick = onClick) {
            Text("Proceed")
        }
    }
}



private const val FIRST_SCREEN = "FIRST_SCREEN"
private const val SECOND_SCREEN = "SECOND_SCREEN"

Comments

ti...@google.com <ti...@google.com> #2Dec 14, 2020 06:59PM

Assigned to an...@google.com.

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. OPP1.170223.012)

Which device did you use to reproduce this issue?

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

qu...@gmail.com <qu...@gmail.com> #3Jan 6, 2021 11:52AM

Android version: T

Problem recurrence: Execute Antutu, and pay attention to the XML processing score

Phenomenon: replace the "name expected" in the KXmlParser.java file on the ssi side with a variable. After modification, the XML processing score of Angora Rabbit improved significantly.

Modify to: static final private String NAME_ EXPECTED = "name expected"; And use NAME_ EXPECTED for subsequent "name expected"

Thanks!

ti...@google.com <ti...@google.com> #4Jan 6, 2021 09:56PM

Thanks for the above information, please share the bug report as requested in comment#2.

ma...@google.com <ma...@google.com> #5Jan 7, 2021 05:08PM

bugreport has upload. Thankds!

lp...@google.com <lp...@google.com> #6Jan 7, 2021 05:47PM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

qu...@gmail.com <qu...@gmail.com> #7Jan 18, 2021 06:47AM

Okay, thanks!

ma...@gmail.com <ma...@gmail.com> #8Mar 21, 2021 01:24AM

Can you tell us if you have the link to the benchmark tests and the scores BEFORE and AFTER applying this change?

an...@google.com <an...@google.com> #9Mar 31, 2021 03:01PM

Reassigned to jb...@google.com.

The score change is mainly reflected in the data processing in Antutu (including xml and json)

About 45000 before modification

About 49000 after modification

Thanks!

qu...@gmail.com <qu...@gmail.com> #10Mar 31, 2021 04:25PM

Thanks for the above information, we have shared this with our product and engineering team and will update this issue with more information as it becomes available.

an...@google.com <an...@google.com> #11Mar 31, 2021 04:54PM

Thanks again for the feedback! Our product and engineering teams have evaluated the request and responded:

However, I can't find the source codes of the Antutu benchmarks.

Here are my suggestions, and you can consider one of the following options:

Can you provide the source code of benchmark to reproduce the result? Particularly, why do you mention that it improves the performance of JSON parsing? It would be great that we can reproduce the result and runs the benchmark continuously if the benchmark result is important
If you know how to change the code, you can consider uploading a patch to AOSP directly at http://r.android.com/. We will review it and consider accepting it.

qu...@gmail.com <qu...@gmail.com> #12Mar 31, 2021 04:59PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

an...@google.com <an...@google.com> #13Mar 31, 2021 05:11PM

We are closing this issue since we didn't receive a response. If you are still facing this problem, please open a new issue and add the relevant information along with reference to this issue.

qu...@gmail.com <qu...@gmail.com> #14Mar 31, 2021 05:23PM

Alright. I guess this would hit two issues at the same time then. Thank you!

Message last modified on Mar 31, 2021 05:23PM

il...@google.com <il...@google.com> #15Jun 2, 2021 11:21PM

Note that if you want to pad in all screens, you should passing the padding directly to NavHost rather than manually to each screen:

) { padding ->
        NavHost(navController, startDestination = FIRST_SCREEN, Modifier.padding(padding)) {
            composable(FIRST_SCREEN) {
                MyScreen(Color.Blue) {
                    navController.navigate(SECOND_SCREEN)
                }
            }
            composable(SECOND_SCREEN) {
                MyScreen(Color.Red) {
                    navController.navigate(FIRST_SCREEN)
                }
            }
        }
    }
}

This was made possible in b/175125483 and was part of Navigation Compose 1.0.0-alpha10.

ap...@google.com <ap...@google.com> #16Jul 2, 2021 06:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 294e5e2a1f2933cb927f9ad2bdd7763923295f49
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jun 21 14:15:54 2021

Override equals in NavGraph and NavDestinations

Instead of relying on the default equals() behavior that requires
NavGraphs and NavDestinations to be the exact instance to be
considered equal, we should specifically define equals to be objects
with the same values, even if they instances are not exactly the same.

RelNote: "`NavGraph` and `NavDestination`s now override the equals method so
two objects with the same values will be considered equal."
Test: NavGraphTest and NavDestinationAndroidTest
Bug: 175392262

Change-Id: I166eb54122cabc12cc569daea8eefcf8e0ec95a7

M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
M navigation/navigation-common/src/test/java/androidx/navigation/NavGraphTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicGraphNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/ActivityNavigator.kt

https://android-review.googlesource.com/1740057

ap...@google.com <ap...@google.com> #17Jul 15, 2021 01:00AM

Project: platform/frameworks/support
Branch: androidx-main

commit 5e187e759d673ea9c45d7fafe8e98260fe090bd4
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jun 23 13:30:16 2021

Allow the NavGraph to be changed in NavHost

Since NavGraph now implements its own equals based on the data in the
graph rather than the instance, we can stop always remembering the
NavGraph and allow it to be changed on recompose.

RelNote: "You can now make changes to the graph of a NavHost. Graphs
with the same startDestination and destinations in the graph will be
considered equal and will not clear the navController back stack."
Test: setSameGraph
Bug: 175392262

Change-Id: I0b8dbcea4186232c3280c4a43be11e4fafcc6ce3

M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/1745023

jb...@google.com <jb...@google.com> #18Jul 15, 2021 03:41AM

Marked as fixed.

This has been fixed internally and will be part of the Navigation 2.4.0-alpha05 release.