Fixed
Status Update
Comments
tc...@google.com <tc...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3c26f121a99cd3f0d52cb7d60704fa19a7d5ff22
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Apr 01 15:48:42 2020
LifecycleOwner integration
ComponentActivity is now mandatory. We just pass LifecycleOwner directly inside activity.setContent{} to not wait until the View will be attached. When ViewGroup.setContent{} is used we get the value using ViewTreeLifecycleOwner once the view is attached. If it is not available(we are used in just regular Activity or inside AppCompatActivity which currently has a bug and not populating the ViewTreeLifecycleOwner) we use our fake LifecycleRegistry for now(we move it to resumed when view is attached and to stopped when detached). This behavior is to be reconsidered once we fix the bug in AppCompatActivity.
Relnote: "New LifecycleOwnerAmbient is now available. Now an Activity you are using with Compose UI should extend androidx.activity.ComponentActivity (or AppCompatActivity). setContent on android.app.Activity is now deprecated"
Test: manually, plus new tests to ensure the ambient is populated
Fixes: 153141084
Bug: 151835993
Change-Id: Idb25a736332b17aebbfb96e919b932c2cc284d56
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoActivity.kt
M ui/ui-android-view/build.gradle
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/build.gradle
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WrapperTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Wrapper.kt
M ui/ui-framework/src/main/res/values/ids.xml
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/build.gradle
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-test/build.gradle
M ui/ui-test/src/androidTest/java/androidx/ui/test/SendClickTest.kt
M ui/ui-text/src/androidTest/java/androidx/ui/text/TextLayoutTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ComposeViewAdapterTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/PreviewActivityTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/preview/PreviewParameterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/PreviewActivity.kt
https://android-review.googlesource.com/1276352
Branch: androidx-master-dev
commit 3c26f121a99cd3f0d52cb7d60704fa19a7d5ff22
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Apr 01 15:48:42 2020
LifecycleOwner integration
ComponentActivity is now mandatory. We just pass LifecycleOwner directly inside activity.setContent{} to not wait until the View will be attached. When ViewGroup.setContent{} is used we get the value using ViewTreeLifecycleOwner once the view is attached. If it is not available(we are used in just regular Activity or inside AppCompatActivity which currently has a bug and not populating the ViewTreeLifecycleOwner) we use our fake LifecycleRegistry for now(we move it to resumed when view is attached and to stopped when detached). This behavior is to be reconsidered once we fix the bug in AppCompatActivity.
Relnote: "New LifecycleOwnerAmbient is now available. Now an Activity you are using with Compose UI should extend androidx.activity.ComponentActivity (or AppCompatActivity). setContent on android.app.Activity is now deprecated"
Test: manually, plus new tests to ensure the ambient is populated
Fixes: 153141084
Bug: 151835993
Change-Id: Idb25a736332b17aebbfb96e919b932c2cc284d56
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoActivity.kt
M ui/ui-android-view/build.gradle
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/build.gradle
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WrapperTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Wrapper.kt
M ui/ui-framework/src/main/res/values/ids.xml
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/build.gradle
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-test/build.gradle
M ui/ui-test/src/androidTest/java/androidx/ui/test/SendClickTest.kt
M ui/ui-text/src/androidTest/java/androidx/ui/text/TextLayoutTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ComposeViewAdapterTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/PreviewActivityTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/preview/PreviewParameterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/PreviewActivity.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3c26f121a99cd3f0d52cb7d60704fa19a7d5ff22
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Apr 01 15:48:42 2020
LifecycleOwner integration
ComponentActivity is now mandatory. We just pass LifecycleOwner directly inside activity.setContent{} to not wait until the View will be attached. When ViewGroup.setContent{} is used we get the value using ViewTreeLifecycleOwner once the view is attached. If it is not available(we are used in just regular Activity or inside AppCompatActivity which currently has a bug and not populating the ViewTreeLifecycleOwner) we use our fake LifecycleRegistry for now(we move it to resumed when view is attached and to stopped when detached). This behavior is to be reconsidered once we fix the bug in AppCompatActivity.
Relnote: "New LifecycleOwnerAmbient is now available. Now an Activity you are using with Compose UI should extend androidx.activity.ComponentActivity (or AppCompatActivity). setContent on android.app.Activity is now deprecated"
Test: manually, plus new tests to ensure the ambient is populated
Fixes: 153141084
Bug: 151835993
Change-Id: Idb25a736332b17aebbfb96e919b932c2cc284d56
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoActivity.kt
M ui/ui-android-view/build.gradle
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/build.gradle
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WrapperTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Wrapper.kt
M ui/ui-framework/src/main/res/values/ids.xml
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/build.gradle
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-test/build.gradle
M ui/ui-test/src/androidTest/java/androidx/ui/test/SendClickTest.kt
M ui/ui-text/src/androidTest/java/androidx/ui/text/TextLayoutTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ComposeViewAdapterTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/PreviewActivityTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/preview/PreviewParameterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/PreviewActivity.kt
https://android-review.googlesource.com/1276352
Branch: androidx-master-dev
commit 3c26f121a99cd3f0d52cb7d60704fa19a7d5ff22
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Apr 01 15:48:42 2020
LifecycleOwner integration
ComponentActivity is now mandatory. We just pass LifecycleOwner directly inside activity.setContent{} to not wait until the View will be attached. When ViewGroup.setContent{} is used we get the value using ViewTreeLifecycleOwner once the view is attached. If it is not available(we are used in just regular Activity or inside AppCompatActivity which currently has a bug and not populating the ViewTreeLifecycleOwner) we use our fake LifecycleRegistry for now(we move it to resumed when view is attached and to stopped when detached). This behavior is to be reconsidered once we fix the bug in AppCompatActivity.
Relnote: "New LifecycleOwnerAmbient is now available. Now an Activity you are using with Compose UI should extend androidx.activity.ComponentActivity (or AppCompatActivity). setContent on android.app.Activity is now deprecated"
Test: manually, plus new tests to ensure the ambient is populated
Fixes: 153141084
Bug: 151835993
Change-Id: Idb25a736332b17aebbfb96e919b932c2cc284d56
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoActivity.kt
M ui/ui-android-view/build.gradle
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/build.gradle
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WrapperTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Wrapper.kt
M ui/ui-framework/src/main/res/values/ids.xml
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/build.gradle
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-test/build.gradle
M ui/ui-test/src/androidTest/java/androidx/ui/test/SendClickTest.kt
M ui/ui-text/src/androidTest/java/androidx/ui/text/TextLayoutTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ComposeViewAdapterTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/PreviewActivityTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/preview/PreviewParameterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/PreviewActivity.kt
Description
items(n = 10) { index: Int ->
...
}
will solve most of the use cases and would allow items(list) to be implemented on top of it