Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit b455a8d72781296c2368b1ebfde7bfeb7c154213
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Sep 23 17:11:53 2021
InputModeManager
Add a composition local that provides an APIs to:
1) check if the system is in touch mode
2) programmatically switch to non-touch mode
Bug: 175899786
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.input.InputModeTest
Relnote: "Added LocalInputModeManager CompositionLocal to detect TouchMode/NonTouchMode."
Change-Id: I6a83c0c04f4da63ffdf287051a2277cb337d7104
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/InputModeTest.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/InputModeManager.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/input/TouchModeDemo.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/1842914
Branch: androidx-main
commit b455a8d72781296c2368b1ebfde7bfeb7c154213
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Sep 23 17:11:53 2021
InputModeManager
Add a composition local that provides an APIs to:
1) check if the system is in touch mode
2) programmatically switch to non-touch mode
Bug: 175899786
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.input.InputModeTest
Relnote: "Added LocalInputModeManager CompositionLocal to detect TouchMode/NonTouchMode."
Change-Id: I6a83c0c04f4da63ffdf287051a2277cb337d7104
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/InputModeTest.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/InputModeManager.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/input/TouchModeDemo.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/api/public_plus_experimental_current.txt
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 075d302e6f70ea948b502d54afe577685f2e9cc3
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jan 04 16:46:09 2023
Use return value of requestFocus()
The public FocusRequester.requestFocus() does not return anything,
but with the refactor in aosp/2286277 requestFocus() returns a
boolean value. This CL uses that value during focus search.
This might help fix b/262715020
Bug: 175899786
Bug: 262715020
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.ui.focus
Change-Id: If541a9517f49cbc2a0ef40a325ccc53bf13ed931
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
https://android-review.googlesource.com/2376851
Branch: androidx-main
commit 075d302e6f70ea948b502d54afe577685f2e9cc3
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jan 04 16:46:09 2023
Use return value of requestFocus()
The public FocusRequester.requestFocus() does not return anything,
but with the refactor in aosp/2286277 requestFocus() returns a
boolean value. This CL uses that value during focus search.
This might help fix
Bug: 175899786
Bug: 262715020
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.package=androidx.compose.ui.focus
Change-Id: If541a9517f49cbc2a0ef40a325ccc53bf13ed931
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
na...@google.com <na...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.4.0-alpha04
Description
Android has a Touch/Non-Touch mode which influences which items are focusable and which ones are not. Implement a similar concept in Compose.