Outer transaction must be marked successfully in WorkerWrapper [175944460]

Fixed

Bug

Status Update

No update yet.

Description

ac...@gmail.com

created issue #1

Dec 19, 2020 03:49AM

Component used: WorkManager
Version used: all version including 2.5.0-rc01
Devices/Android versions reproduced on: Motorola G 7.0 (SDK 24), 7.1 (SDK 25)

Related source code:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java#193
mWorkDatabase.setTransactionSuccessful() must be called after calling resolve(true) line 193. Nested transactions will be rolled back if the outer transaction isn't marked as successful.
This behavior causes crashes on Motorola devices with 7.0/7.1

See crash report from Google Play for Motorola devices.

Fri Dec 18 2020 19:49:24 GMT-0800 (Pacific Standard Time).png

145 KB

View

Download

Comments

ra...@google.com <ra...@google.com> Dec 21, 2020 10:58PM

Assigned to ra...@google.com.

ra...@google.com <ra...@google.com> #2Dec 25, 2020 10:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d00acd443e0e5dd2cc33eb314a65f78f21cec61
Author: Calin Tataru <calintat@google.com>
Date: Mon Aug 10 17:59:53 2020

Modifier.swipeable polishing

This CL does the following things:
* Expand the documentation in SwipeableState.
* Make the setter of SwipeableState.value private.
* Rename some of the properties in SwipeableState, and slightly change
the definition of swipeTarget (now called targetValue) so that it uses
the target value of the ongoing animation if isAnimationRunning = true.
* Add a rememberSwipeableState function to help reduce boilerplate.
* Add Savers for [Drawer/BottomDrawer/Dismiss/Swipeable]State, so that
we can use rememberSavedInstanceState in the rememberFooState functions.

Bug: 163129614
Bug: 163132293
Test: Ran SwipeableTest and other tests depending on swipeable
Relnote: "Renamed some properties in SwipeableState: swipeTarget ->
targetValue, swipeProgress -> progress, swipeDirection -> direction.
Added a rememberSwipeableState function for creating SwipeableStates."
Change-Id: I2fc9c3af465b579a18359ae0aa0853c2d2b02abe

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeToDismissSamples.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeableSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeableTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/SwipeToDismiss.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Switch.kt

https://android-review.googlesource.com/1396349

ap...@google.com <ap...@google.com> #3Dec 28, 2020 05:10PM

Marked as fixed.

I added a rememberSwipeableState function to easily create and remember a SwipeableState with the default animation clock. That should work perfectly for your usecase.

ac...@gmail.com <ac...@gmail.com> #4Dec 28, 2020 07:00PM

Regression in material3: the function is now marked internal. Please re-open.

ra...@google.com <ra...@google.com> #5Dec 28, 2020 07:02PM

https://cs.android.com/androidx/platform/frameworks/support/+/4e99cad7cfba400da47af86a08f68df6b40c6e51

ac...@gmail.com <ac...@gmail.com> #6Mar 16, 2021 06:47PM

Thanks for your feedback. We are looking into the ways of improving the current Mosidifer.swipeable, it has a number of critical bugs and we don't want to publish it as-is in material3. Stay tuned

Issue 175944460