Outer transaction must be marked successfully in WorkerWrapper [175944460]

Fixed

Bug

Status Update

No update yet.

Description

ac...@gmail.com

created issue #1

Dec 19, 2020 03:49AM

Component used: WorkManager
Version used: all version including 2.5.0-rc01
Devices/Android versions reproduced on: Motorola G 7.0 (SDK 24), 7.1 (SDK 25)

Related source code:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java#193
mWorkDatabase.setTransactionSuccessful() must be called after calling resolve(true) line 193. Nested transactions will be rolled back if the outer transaction isn't marked as successful.
This behavior causes crashes on Motorola devices with 7.0/7.1

See crash report from Google Play for Motorola devices.

Fri Dec 18 2020 19:49:24 GMT-0800 (Pacific Standard Time).png

145 KB

View

Download

Comments

ra...@google.com <ra...@google.com> Dec 21, 2020 10:58PM

Assigned to ra...@google.com.

ra...@google.com <ra...@google.com> #2Dec 25, 2020 10:10PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3Dec 28, 2020 05:10PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ac...@gmail.com <ac...@gmail.com> #4Dec 28, 2020 07:00PM

deleted

ra...@google.com <ra...@google.com> #5Dec 28, 2020 07:02PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ac...@gmail.com <ac...@gmail.com> #6Mar 16, 2021 06:47PM

Thanks. Picked up the new workmanager build and no more issue happens again on Motorola devices.

Issue 175944460