Fixed
Status Update
No update yet.
Comments
ra...@google.com
ra...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ac...@gmail.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
ra...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
ac...@gmail.com
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
Description
Version used: all version including 2.5.0-rc01
Devices/Android versions reproduced on: Motorola G 7.0 (SDK 24), 7.1 (SDK 25)
Related source code:
mWorkDatabase.setTransactionSuccessful() must be called after calling resolve(true) line 193. Nested transactions will be rolled back if the outer transaction isn't marked as successful.
This behavior causes crashes on Motorola devices with 7.0/7.1
See crash report from Google Play for Motorola devices.