Fixed
Status Update
No update yet.
Comments
ro...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
https://android-review.googlesource.com/1911432
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
uw...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/1910055
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e8d484789c3d8dc134b9ecf1d4e282f51223920c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 22:22:39 2021
Migrate top-level androidx.work.impl.constraints to Kotlin
bug: 209145335
Test: refactoring, test passes
Change-Id: I0dc5e63898a3b2b2668059bf163a7573de8a932a
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
https://android-review.googlesource.com/1910059
Branch: androidx-main
commit e8d484789c3d8dc134b9ecf1d4e282f51223920c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 22:22:39 2021
Migrate top-level androidx.work.impl.constraints to Kotlin
bug: 209145335
Test: refactoring, test passes
Change-Id: I0dc5e63898a3b2b2668059bf163a7573de8a932a
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
ro...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 2c5b5f38cc45864ee52c3475360d5a931fd5e2bb
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:56:38 2021
Rename top-level *.java to *.kt in androidx.work.impl.constraints
bug: 209145335
Test: NA
Change-Id: I8c9f0f410eadd940fd859512c2879b46c2bb20b0
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
https://android-review.googlesource.com/1910058
Branch: androidx-main
commit 2c5b5f38cc45864ee52c3475360d5a931fd5e2bb
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:56:38 2021
Rename top-level *.java to *.kt in androidx.work.impl.constraints
bug: 209145335
Test: NA
Change-Id: I8c9f0f410eadd940fd859512c2879b46c2bb20b0
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
Description
DataStore Version used: 1.0.0-alpha05
Devices/Android versions reproduced on: not relevant
The method parameter of Context.createDataStore and DataStoreFactory.create should use the interface CorruptionHandler instead of an implementation of the interface (ReplaceFileCorruptionHandler)