Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Device used
Which device did you use to reproduce this issue?
Steps to reproduce
What steps are needed to reproduce this issue?
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Android bug report capturing
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory. Attach the bug report file to this issue.
Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.
NOTE : To avoid leaking private information, please share screenshots and bugreports only in Google Drive. Share files with android-bugreport@google.com and include only Google drive links in your bug. Bug report attachments should not be included directly in issue reports.
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Device used
Which device did you use to reproduce this issue?
Steps to reproduce
What steps are needed to reproduce this issue?
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Android bug report capturing
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory. Attach the bug report file to this issue.
Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.
NOTE : To avoid leaking private information, please share screenshots and bugreports only in Google Drive. Share files with android-bugreport@google.com and include only Google drive links in your bug. Bug report attachments should not be included directly in issue reports.
cs...@gmail.com <cs...@gmail.com> #4
Attached is a sample project that demonstrates the issue in two ways:
- when long pressing text (e.g. the headline)
- when opening a select
Both will ultimately load an alert dialog with a list adapter that has the layout ids for the content set to 0.
https://drive.google.com/file/d/1Fe2ym2F0o4XWEDHvKY8-UzpvSJq4wbWq/view?usp=drive_web (WebViewAppCompatBug.zip)
This is reproducible on an API 21 emulator (Nexus 5 configuration, no Chrome installed).
NB There is a second issue when loading the web view in the first place which in this sample project is worked around by using a resource wrapper. This is already reported underhttps://issuetracker.google.com/issues/140884278 and the attached project will also display this error when commenting out lines 13-15 in MainActivity.kt.
- when long pressing text (e.g. the headline)
- when opening a select
Both will ultimately load an alert dialog with a list adapter that has the layout ids for the content set to 0.
This is reproducible on an API 21 emulator (Nexus 5 configuration, no Chrome installed).
NB There is a second issue when loading the web view in the first place which in this sample project is worked around by using a resource wrapper. This is already reported under
al...@google.com <al...@google.com>
al...@google.com <al...@google.com> #5
Please take a look at this issue and provide your inputs.
ap...@google.com <ap...@google.com> #6
Wrapping Resources is not supported by the framework and you must not create your own instances of Resources at all (the APIs to do so are now marked deprecated after they were accidentally exposed).
We can't do anything to fix this - you need to solve the underlying problem with appcompat and stop wrapping it like this, and then resources will work.
We can't do anything to fix this - you need to solve the underlying problem with appcompat and stop wrapping it like this, and then resources will work.
al...@google.com <al...@google.com> #7
While I agree this is WontFIx from WebView's perspective (the WebView APK in question already shipped), it seems like this should still be considered a regression from appcompat's perspective, given the community can no longer test on lower-level emulators. We've received several unique user reports of this issue, not to mention the internal reports which led to filing issue 139710458 .
Surprisingly, issue 142086375 claims this bug repros on Marshmallow, which is something we haven't observed so far and doesn't fit into the current hypothesis:
> in Android 6.0 (API 23) it crashes on tapping the <select> element.
---
From issue 141132133 :
> This change is the root cause:https://android.googlesource.com/platform/frameworks/support/+/26079d87c79a64829f036236353fac1dae4e0613%5E%21/#F2
>
> sAlwaysOverrideConfiguration forces updating the Resources configuration and therby messing up the webview inflation on older devices.
Chis, any chance this checks out? I didn't look too closely into this, so I'm not sure if there are consequences to not overriding the configuration on L-M only, or perhaps further limited old WebView versions only.
Surprisingly,
> in Android 6.0 (API 23) it crashes on tapping the <select> element.
---
From
> This change is the root cause:
>
> sAlwaysOverrideConfiguration forces updating the Resources configuration and therby messing up the webview inflation on older devices.
Chis, any chance this checks out? I didn't look too closely into this, so I'm not sure if there are consequences to not overriding the configuration on L-M only, or perhaps further limited old WebView versions only.
al...@google.com <al...@google.com> #8
Same problem appear simply by using a WebView on Android 5 / 5.1 (on actual devices, no emulator) with appcompat:1.1.0 directly causing a crash (on display, no interaction needed).
al...@google.com <al...@google.com> #9
Dropping the priority of this, since there's no feasible fix for this.
al...@google.com <al...@google.com> #10
So, a bug that was laser-focused and easily reproduced by simply including a WebView in an Activity crashing on Android 5 / 5.1 devices with appcompat-1.1.0 but not appcompat-1.1.0-rc01 was marked as duplicate of this, and somehow despite knowing the commit that caused it and being able to reproduce it, and not crashing from Android 5 until that commit it is not feasible to fix. Seems odd to me given the commit seemed to enable a feature, meaning that the choice is crash or have a feature (which you can't use because you crashed). Wouldn't it be better to just not support that feature fully vs crash? Just a thought
al...@google.com <al...@google.com> #11
We got this crash on a Samsung Nexus 10 with Android 5.1.1 at 100% on any WebView
ap...@google.com <ap...@google.com> #12
Can this be changed back to p2 priority? Phrase "no feasible fix" is not enouth to ignore application crash and make this less importaint
al...@google.com <al...@google.com> #13
I'm not sure if you can see the duplicate of this ticket. We have lots of tickets which have different causes of the WebView crashes are marked as duplicate with no clarification.
Here is one of them.
https://issuetracker.google.com/issues/141436946
It will be great if you can take some time to revisit duplicate tickets. I believe a lot of developer are looking for the fix or workaround.
Thank you!
Here is one of them.
It will be great if you can take some time to revisit duplicate tickets. I believe a lot of developer are looking for the fix or workaround.
Thank you!
Description
Component used: appcompat-resources (androidx.appcompat) Version used: 1.1.0 Devices/Android versions reproduced on: OS 4.x (Jelly bean, Kitkat)
Issue Description I am trying to fetch strings via my own
Resources
object for non-English locales. In the attached project, my Hindi string is stored inassets
folder. When I run the app on OS 5 and above, the string is correctly displayed (fetched from assets), whereas, when I run the app on OS 4.3 or (OS < 5.0) it displays English string instead of the correct locale. After debugging I found that when I haveAppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
, on low end devices, it wraps Resources object (my object) intoVectorEnabledTintResources
object. In this class onlygetDrawable
is overridden but the rest of the calls are passed over to the parentResources
object instead ofbaseResources
causing the issue.Suggestion Extend
VectorEnabledTintResources
fromResourcesWrapper
or delegate the rest of the calls to the passedResources
objectAttachments
AppCompatDelegate.setCompatVectorFromResourcesEnabled(false);
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true);