Replacing Fragment in onViewCreated fails when transaction happens in lifecycle scope - Regression in 1.3.0-r01 [176138645]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 23, 2020 01:53PM

Component used: Fragment Version used: 1.3.0-rc01 Devices/Android versions reproduced on: No specific version

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

With Fragment 1.3.0-rc01, doing a fragment transaction in viewLifecycleOwner.lifecycleScope in the onViewCreated crashes the application.

Crash doesn't happen if transaction happen outside of viewLifecycleOwner.lifecycleScope or if we use launchWhenStarted instead of launch.

I used NavigationBasicSample application with updated fragment library version (1.3.0-rc01) and added onViewCreated method in TitleScreen

Added code to reproduce the crash.

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        viewLifecycleOwner.lifecycleScope.launch {
            parentFragmentManager.beginTransaction()
                    .replace(R.id.my_nav_host_fragment, Register())
                    .commit()
//            Both of them fails
//            findNavController(this@TitleScreen).navigate(R.id.action_title_screen_to_register)
        }

//        Calling navigation outside of the lifecycle scope doesn't crash
//        parentFragmentManager.beginTransaction()
//                .replace(R.id.my_nav_host_fragment, Register())
//                .commit()
    }

com.example.android.navigationsample E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.android.navigationsample, PID: 22161
    java.lang.IllegalStateException: no event down from INITIALIZED
        at androidx.lifecycle.LifecycleRegistry.backwardPass(LifecycleRegistry.java:281)
        at androidx.lifecycle.LifecycleRegistry.sync(LifecycleRegistry.java:302)
        at androidx.lifecycle.LifecycleRegistry.moveToState(LifecycleRegistry.java:148)
        at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent(LifecycleRegistry.java:134)
        at androidx.fragment.app.FragmentViewLifecycleOwner.handleLifecycleEvent(FragmentViewLifecycleOwner.java:62)
        at androidx.fragment.app.Fragment.performDestroyView(Fragment.java:3182)
        at androidx.fragment.app.FragmentStateManager.destroyFragmentView(FragmentStateManager.java:739)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:346)
        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2177)
        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2088)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1990)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3122)
        at androidx.fragment.app.FragmentManager.dispatchViewCreated(FragmentManager.java:3049)
        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2975)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:543)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
        at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1636)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3112)
        at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3056)
        at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
        at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:473)
        at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:210)
        at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1435)
        at android.app.Activity.performStart(Activity.java:8024)
        at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3475)
        at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221)
        at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
        at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

NavigationBasicSample.zip

1.7 MB

Download

Comments

il...@google.com <il...@google.com> Jan 8, 2021 12:03AM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #2Jan 16, 2021 03:20AM

Marked as fixed.

Please include a sample project that reproduces your issue.

jb...@google.com <jb...@google.com> #3Jan 19, 2021 11:19PM

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

ku...@gmail.com <ku...@gmail.com> #4Jan 21, 2021 05:31PM

Hello, have you checked sample project? I hope it will help find the issue.

il...@google.com <il...@google.com> #5Jan 21, 2021 05:52PM

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

ra...@gmail.com <ra...@gmail.com> #6Feb 1, 2021 04:09PM

Hello, any update please?

il...@google.com <il...@google.com> #7Feb 1, 2021 05:10PM

Hello I raised similar issue with this ticket https://issuetracker.google.com/issues/249247706

This makes the SearchView unusable/broken when fragments are changed (i.e base on searchView input query)

What can we do to fix this problem? What is the progress of work on solving this problem?

[Deleted User] <[Deleted User]> #8Feb 7, 2021 09:39AM

@7 Check @5 for a workaround.

il...@google.com <il...@google.com> #9Feb 7, 2021 09:54PM

Hi, i am also facing this issue after we dismiss a DialogFragment, the callback comes in the onPrepareOptionsMenu(), which is causing the issues for me.
Any idea on when it will be fixed?

sa...@rebelfoods.com <sa...@rebelfoods.com> #10Mar 16, 2021 04:57AM

Hello, any estimate please?

sa...@rebelfoods.com <sa...@rebelfoods.com> #11Mar 16, 2021 05:00AM

Facing a similar kind of issue when scrolling the fragments using a ViewPager.

https://issuetracker.google.com/issues/267677504

Can you update regarding any progress on this issue.

jb...@google.com <jb...@google.com> #12Mar 16, 2021 03:35PM

I wonder if the new SearchBar has this issue:

https://material.io/blog/android-stable-release-1-8-0