Lifecycle as Flow [176311030]

Fixed

Feature Request

Status Update

No update yet.

Description

p1...@gmail.com

created issue #1

Dec 25, 2020 09:24PM

Please provide extension for lifecycle to observe Lifecycle.Event as Flow.

Also present you my workaround

fun Lifecycle.asFlow() = callbackFlow<Lifecycle.Event> {

val observer = ALifecycleObserver(this@asFlow) { offer(it) }

awaitClose { removeObserver(observer) }

}

class ALifecycleObserver(
lifecycle: Lifecycle,
private val action: (Lifecycle.Event) -> Unit
): LifecycleObserver {

init { lifecycle.addObserver(this) }

@OnLifecycleEvent(Lifecycle.Event.ON_CREATE)
fun onCreate(event: Lifecycle.Event) = action.invoke(event)

@OnLifecycleEvent(Lifecycle.Event.ON_START)
fun onStart(event: Lifecycle.Event) = action.invoke(event)

@OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
fun onResume(event: Lifecycle.Event) = action.invoke(event)

@OnLifecycleEvent(Lifecycle.Event.ON_PAUSE)
fun onPause(event: Lifecycle.Event) = action.invoke(event)

@OnLifecycleEvent(Lifecycle.Event.ON_STOP)
fun onStop(event: Lifecycle.Event) = action.invoke(event)

@OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
fun onDestroy(event: Lifecycle.Event) = action.invoke(event)
}

Comments

p1...@gmail.com <p1...@gmail.com> #2Dec 25, 2020 11:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

se...@google.com <se...@google.com> #3Jan 6, 2021 01:22PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

p1...@gmail.com <p1...@gmail.com> #4Jan 6, 2021 01:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

il...@google.com <il...@google.com> Nov 18, 2021 10:12PM

Status: New

ca...@google.com <ca...@google.com> #5Jan 28, 2022 06:40PM

This is something I also added as a workaround. It seems like a natural API to include in Jetpack.

il...@google.com <il...@google.com> Sep 12, 2022 11:51PM

Assigned to sa...@google.com.

ey...@gmail.com <ey...@gmail.com> #6Jan 17, 2023 10:59PM

I was very surprised that this wasn't included in Jetpack.

it...@gmail.com <it...@gmail.com> #7Jan 20, 2023 01:16AM

I ended up incorporating this workaround, too. Makes a ton of sense to make this observable.

sa...@google.com <sa...@google.com> Feb 8, 2023 10:41PM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #8Mar 3, 2023 10:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2f35da31af699a8b91439c53d9eb43840da6551b
Author: sanura <sanura@google.com>
Date: Thu Feb 09 01:47:28 2023

Expose Lifecycle as a Flow<Lifecycle.Event>

Adding an extension method to Lifecycle that
will allow observing Lifecycle.Event as a Flow.

RelNote: "`Lifecycle.Event`s are now able to be
observed as a `Flow` with `Lifecycle.asFlow().`"
Bug: 176311030
Test: LifecycleAsFlowTest

Change-Id: If2c0f10760caca7109d43c235ea76437ef2af5dc

M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/build.gradle
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycle.kt
A lifecycle/lifecycle-runtime-testing/src/test/java/androidx/lifecycle/testing/LifecycleEventFlowTest.kt

https://android-review.googlesource.com/2427280

it...@gmail.com <it...@gmail.com> #9Mar 4, 2023 12:18AM

#8 you might want to remove that email from your comment, as emails are typically obfuscated in these threads

sa...@google.com <sa...@google.com> Mar 6, 2023 07:43PM

Marked as fixed.

na...@google.com <na...@google.com> #10Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-common:2.7.0-alpha01
androidx.lifecycle:lifecycle-runtime-testing:2.7.0-alpha01