Span count for LazyVerticalGrid [176758183]

Fixed

Bug

Status Update

No update yet.

Description

gu...@gmail.com

created issue #1

Jan 5, 2021 04:26PM

Currently LazyVerticalGrid accepts GridCells only Fixed or Adaptive. However as in GridLayoutManager, we should be able to define span count per item.

Comments

ma...@google.com <ma...@google.com> Jan 6, 2021 04:24PM

Assigned to an...@google.com.

an...@google.com <an...@google.com> Jun 18, 2021 03:42PM

Reassigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Nov 9, 2021 06:57PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jo...@gmail.com <jo...@gmail.com> #3Nov 18, 2021 10:34PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Thu Nov 18 2021 15:28:48 GMT-0700 (Mountain Standard Time).png

3 KB

View

Download

Thu Nov 18 2021 15:31:12 GMT-0700 (Mountain Standard Time).png

5.3 KB

View

Download

ld...@gmail.com <ld...@gmail.com> #4Nov 19, 2021 04:45PM

Comment has been deleted.

Message last modified on Nov 19, 2021 04:46PM

jo...@gmail.com <jo...@gmail.com> #5Nov 19, 2021 04:47PM

I have found a solution for this so long as I know how many columns there are, I mainly use GridCells.Adaptive. If the number of columns can be passed to the content block I am good to go.

po...@google.com <po...@google.com> #6Nov 23, 2021 10:47AM

Re #comment3, thanks for reporting. Initially this was WAI, but I see how this is inconvenient. Filed b/207462103 to track fixing this.

te...@gmail.com <te...@gmail.com> #7Dec 2, 2021 11:17AM

How does this work if we are using GridCells.Adaptive(300.dp) ? I've tried specifying GridItemSpan(Int.MAX_VALUE) but it doesn't seem to work.
Also doesn't LazyVerticalGrid have a key that you can specify for each item like LazyColumn? Won't scroll position get lost if that's the case?

po...@google.com <po...@google.com> #8Dec 2, 2021 11:54AM

How does this work if we are using GridCells.Adaptive(300.dp)

The number of columns will be calculated according to the available width and then the behaviour will be the same as with GridCells.Fixed

I've tried specifying GridItemSpan(Int.MAX_VALUE) but it doesn't seem to work.

Hmm, what would be the expected behaviour here? The span will just be limited to the number of columns.

doesn't LazyVerticalGrid have a key It will. Note LazyVerticalGrid is still experimental and not feature complete / API stable.