Fixed
Status Update
Comments
cu...@google.com <cu...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 32e15d7e6a58276987c27730dcc01ecfb950d2db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:07:46 2024
Convert `lifecycle-runtime-compose` to multiplatform
* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225
Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: I4f4a03613120f3222bd44ae1feab1a085ddb38da
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt
https://android-review.googlesource.com/3017203
Branch: androidx-main
commit 32e15d7e6a58276987c27730dcc01ecfb950d2db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:07:46 2024
Convert `lifecycle-runtime-compose` to multiplatform
* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225
Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: I4f4a03613120f3222bd44ae1feab1a085ddb38da
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt
re...@infinum.com <re...@infinum.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 195d70fcd1b8d7dea6820e1795584e29e7535c84
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:14:40 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I8e79f3d5a7b6586dac65ae4c7d3868d9518ee585
M lifecycle/lifecycle-runtime-compose/build.gradle
https://android-review.googlesource.com/3017204
Branch: androidx-main
commit 195d70fcd1b8d7dea6820e1795584e29e7535c84
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:14:40 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I8e79f3d5a7b6586dac65ae4c7d3868d9518ee585
M lifecycle/lifecycle-runtime-compose/build.gradle
Description
If this is a bug in the library, we would appreciate if you could attach:
BUILD INFO
STEPS TO REPRODUCE [Be as specific as possible please]
EXPECTED RESULTS
I expect available hardware for these devices because they do have a Fingerprint sensor and they do classify as BIOMETRIC_STRONG because if run Biometric authentication without any set authenticators the internal lib will set the authenticator to BIOMETRIC_STRONG since I have a crypto object initialised and everything works as expected. The method that is responsible for setting the authenticator to strong is
getConsolidatedAuthenticators(@NonNull BiometricPrompt.PromptInfo info, @Nullable BiometricPrompt.CryptoObject crypto)
inside the first else block:OBSERVED RESULTS
I get a BIOMETRIC_ERROR_HW_UNAVAILABLE inside the BiometricManager class due to the fingerprintManager being null:
the result does not make sense to me because I do have a device which have the appropriate strong classified HW based on the behaviour in the EXPECTED RESULTS section. The fingerprint implementation with the CryptoObject worked fine on 1.0.1 version of the library.
NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE (e.g. 3/10)
10/10